chore: finalize kv structure for queue, workflows, traces, sqlite#4284
Conversation
|
🚅 Deployed to the rivet-pr-4284 environment in rivet-frontend
|
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: chore: finalize kv structure for queue, workflows, traces, sqliteThis PR restructures the actor KV keyspace by adding storage versioning bytes and renumbering top-level namespaces. The intent is clearly to finalize the structure before it becomes immutable in production. The approach is directionally correct — versioned namespaces are the right design — but there are some issues worth flagging. Breaking Change Without MigrationThis is the most significant concern. The PR changes key paths for every major subsystem:
Any actor with existing data under the old scheme will silently lose access to it after this change. There is no migration path. If this is intentional (e.g., actors don't yet have meaningful production data at the old paths), that should be stated explicitly in the PR description to make the intent clear to future readers. Documentation InconsistencyThe new However, Workflow Field VERSION Removal
|
2cb7629 to
1839ce7
Compare
50ef521 to
88cf774
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: