Skip to content

fix: remove useless config params#4319

Open
MasterPtato wants to merge 1 commit into02-26-fix_add_serverless_leak_fix_oneofffrom
02-26-fix_remove_useless_config_params
Open

fix: remove useless config params#4319
MasterPtato wants to merge 1 commit into02-26-fix_add_serverless_leak_fix_oneofffrom
02-26-fix_remove_useless_config_params

Conversation

@MasterPtato
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link

railway-app bot commented Feb 26, 2026

🚅 Deployed to the rivet-pr-4319 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Feb 26, 2026 at 8:30 pm
frontend-inspector 😴 Sleeping (View Logs) Web Feb 26, 2026 at 8:28 pm
frontend-cloud ❌ Build Failed (View Logs) Web Feb 26, 2026 at 8:21 pm
mcp-hub ✅ Success (View Logs) Web Feb 26, 2026 at 8:15 pm
ladle ❌ Build Failed (View Logs) Web Feb 26, 2026 at 8:07 pm

Copy link
Contributor Author

MasterPtato commented Feb 26, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Feb 26, 2026

PR Review: fix: remove useless config params

Good cleanup overall — removing unused/dead config parameters reduces surface area and simplifies configuration. Here are a few issues to address before merging.


Bugs

1. Schema/struct field name mismatch — runner_http_max_response_body_size vs runner_max_response_payload_body_size

The Rust struct was renamed to runner_max_response_payload_body_size (pegboard.rs:102), but the JSON schema still uses the old name runner_http_max_response_body_size (config-schema.json:712). Any existing user config setting runner_http_max_response_body_size will be silently ignored at runtime.

The schema should be regenerated (or manually updated) to use the new field name.

2. Dead field: gateway_http_max_request_body_size has no getter

Pegboard::gateway_http_max_request_body_size still exists as a public struct field (pegboard.rs:98) and in the config schema (config-schema.json:581), but its getter method was removed and it is no longer consumed anywhere. Setting this value in a config file will have no effect.

Either:

  • Remove the field from the struct and schema entirely, or
  • Keep the field and restore/implement a getter that enforces it somewhere

Minor Issues

3. Misleading function name for response body limiting

In proxy_service.rs (line 803–812), the response body buffer limit is enforced using self.state.config.guard().http_max_request_body_size(). This uses a function named for request bodies to limit response bodies. While the 20 MiB limit is the same in both cases right now, this will cause confusion if the two limits ever diverge.

4. Potentially breaking default limit change

Guard::http_max_request_body_size default changed from 256 MiB → 20 MiB, and runner_max_response_payload_body_size changed from 128 MiB → 20 MiB. These are significant reductions that could silently break actors processing larger payloads. The PR checklist has the "Breaking change" box unchecked — worth confirming this is intentional and perhaps calling it out in the description.


Summary

Issue Severity
Schema field name mismatch (runner_http_max_response_body_size in schema vs new name in Rust) Bug
Dead gateway_http_max_request_body_size field (no getter, not enforced) Incomplete cleanup
http_max_request_body_size() used for response body limiting Minor
Undocumented breaking default limit reduction (256→20 MiB, 128→20 MiB) Worth noting

@MasterPtato MasterPtato force-pushed the 02-26-fix_remove_useless_config_params branch from 8831c36 to e21bef6 Compare February 26, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant