chore: flatten runtime config#4326
chore: flatten runtime config#4326MasterPtato wants to merge 1 commit into02-26-chore_deploy_patchfrom
Conversation
|
🚅 Deployed to the rivet-pr-4326 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Code ReviewThis PR flattens the nested Breaking Change (needs documentation)This is a breaking configuration change for anyone using the # Before
runtime:
worker:
cpu_max: 2000
shutdown_duration: 60
gasoline:
prune_eligibility_duration: 604800
# After
runtime:
worker_cpu_max: 2000
worker_shutdown_duration: 60
gasoline_prune_eligibility_duration: 604800The PR description checklist item for "Breaking change" is unchecked, and there's no migration note. Since Docs Not UpdatedPer Minor: Field Visibility Consistency
PR DescriptionThe PR description is empty — no summary of motivation or testing notes. Would help reviewers understand why flattening is preferred here over the nested approach. Overall the implementation is correct and the refactoring is complete (no stale references to the old paths remain). Main ask is to document the breaking change for existing self-hosters. |
|
This change is part of the following stack: Change managed by git-spice. |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: