Skip to content

fix: runner configs being outdated when editing again#4343

Merged
jog1t merged 4 commits intofix-docs-buttonfrom
fix-runner-configs-outdated
Mar 13, 2026
Merged

fix: runner configs being outdated when editing again#4343
jog1t merged 4 commits intofix-docs-buttonfrom
fix-runner-configs-outdated

Conversation

@jog1t
Copy link
Contributor

@jog1t jog1t commented Mar 3, 2026

Closes RVT-6025

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jog1t
Copy link
Contributor Author

jog1t commented Mar 3, 2026

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4343 March 3, 2026 21:46 Destroyed
@railway-app
Copy link

railway-app bot commented Mar 3, 2026

🚅 Deployed to the rivet-pr-4343 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-inspector 😴 Sleeping (View Logs) Web Mar 11, 2026 at 10:13 pm
frontend-cloud 😴 Sleeping (View Logs) Web Mar 11, 2026 at 10:12 pm
ladle ❌ Build Failed (View Logs) Web Mar 11, 2026 at 1:41 pm
website 😴 Sleeping (View Logs) Web Mar 3, 2026 at 9:58 pm
mcp-hub ✅ Success (View Logs) Web Mar 3, 2026 at 9:47 pm

@claude
Copy link

claude bot commented Mar 3, 2026

PR Review

BUGS

  1. Inverted Zod validation + console.log in prod
    File: frontend/src/app/forms/upsert-deployment-form.tsx
    The superRefine condition uses !!data.image.tag which is backwards - it fires when a tag IS provided, but should fire when tag is MISSING. Should be !data.image.tag. The console.log(data) debug statement must also be removed.

  2. Query used as mutation for token creation
    File: frontend/src/app/data-providers/cloud-data-provider.tsx
    createApiTokenQueryOptions calls apiTokens.create() inside queryFn, which is a write operation. React Query reruns queries on cache miss and window focus. staleTime: Infinity reduces but does not eliminate this risk. This should be a mutation or use an idempotent endpoint.

SECURITY

  1. Secret tokens displayed in agent instructions
    File: frontend/src/app/dialogs/connect-rivet-frame.tsx
    RIVET_ENDPOINT and RIVET_TOKEN (including the cloud token) are embedded in a copyable UI code snippet. This is a screen-sharing and screenshot risk. Tokens should be masked by default with an explicit reveal step and a sensitive credential warning.

CODE QUALITY

  1. DeploymentsLink uses useSuspenseQuery in sidebar without error boundary
    File: frontend/src/app/layout.tsx
    useSuspenseQuery throws on error and will crash the entire sidebar if the managed pool query fails. Add an error boundary around DeploymentsLink, or switch to useQuery returning null on error.

  2. Fire-and-forget mutation with no error handling
    File: frontend/src/app/dialogs/connect-rivet-frame.tsx
    The upsertManagedPool call in useEffect has no .catch or onError handler. Silent failures leave users with no feedback that pool setup failed.

  3. Unused imports in deployments.logs.tsx
    Select, SelectContent, SelectItem, SelectTrigger, SelectValue are imported but unused (RegionSelect is used instead).

  4. Style issues in data.ts
    frontend/src/lib/data.ts uses 4-space indentation (project uses 2-space for TypeScript) and is missing a trailing newline.

MINOR

  • Spurious blank line inside mutationCache config object in frontend/src/queries/global.ts
  • Double blank line in frontend/src/components/hooks/use-dialog.tsx

GOOD CHANGES

  • invalidateQueries to refetchQueries is the correct fix for stale UI after mutations
  • maxRetries: 1 on the fetch client prevents runaway retries
  • Global mutations retry: 0 is cleaner than per-mutation retry config
  • isVersionOutdated semver helper with pre-release support is well-implemented
  • ErrorDetails/ErrorDetailsContent split cleanly enables reuse without the accordion wrapper
  • Step visibility system (isVisible, getNextVisibleStepId) in stepper form is a clean approach to conditional steps

SUMMARY: Main blocking issues: (1) inverted validation + console.log, (2) write operation inside a query, (3) secret token display risk, (4) suspense crash risk in sidebar.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 3, 2026

More templates

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4343

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4343

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4343

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4343

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4343

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4343

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4343

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4343

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4343

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4343

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4343

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4343

commit: ca12a35

@jog1t jog1t changed the title fix/runner-configs-outdated fix: runner configs being outdated when editing again Mar 3, 2026
@linear
Copy link

linear bot commented Mar 3, 2026

@jog1t jog1t force-pushed the fix-docs-button branch from 0b536d6 to 394e668 Compare March 11, 2026 13:40
@jog1t jog1t force-pushed the fix-runner-configs-outdated branch from eaf16db to d68e1f0 Compare March 11, 2026 13:40
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4343 March 11, 2026 13:41 Destroyed
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4343 March 11, 2026 22:02 Destroyed
* fix/firefox-modals

* feat(frontend): add additional debug information when actor inspector fails to load (#4346)

* feat/debug-inspector-info

* feat: add deployments route (#4357)

* feat: add deployments route

* new endpoints

* feat: deployments

* feat: deployments

* fix ts issues

* fix

* fix

* fixes

* fixes

* fixes

* fixes

* fixes
@jog1t jog1t merged commit ac9ef12 into fix-docs-button Mar 13, 2026
8 of 12 checks passed
@jog1t jog1t deleted the fix-runner-configs-outdated branch March 13, 2026 18:59
jog1t added a commit that referenced this pull request Mar 13, 2026
* fix/docs-button

* fix: invalid docs link

* fix: runner configs being outdated when editing again (#4343)

* fix/runner-configs-outdated

* fix cache management

* fix: modals being stuck opaque on firefox (#4344)

* fix/firefox-modals

* feat(frontend): add additional debug information when actor inspector fails to load (#4346)

* feat/debug-inspector-info

* feat: add deployments route (#4357)

* feat: add deployments route

* new endpoints

* feat: deployments

* feat: deployments

* fix ts issues

* fix

* fix

* fixes

* fixes

* fixes

* fixes

* fixes
jog1t added a commit that referenced this pull request Mar 13, 2026
* fix/new-project-incorrect-redirect

* fix: incorrect redirection after project creation in cloud onboarding

* fix: docs-button (#4342)

* fix/docs-button

* fix: invalid docs link

* fix: runner configs being outdated when editing again (#4343)

* fix/runner-configs-outdated

* fix cache management

* fix: modals being stuck opaque on firefox (#4344)

* fix/firefox-modals

* feat(frontend): add additional debug information when actor inspector fails to load (#4346)

* feat/debug-inspector-info

* feat: add deployments route (#4357)

* feat: add deployments route

* new endpoints

* feat: deployments

* feat: deployments

* fix ts issues

* fix

* fix

* fixes

* fixes

* fixes

* fixes

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant