Skip to content

chore: improve serverless refresh error#4436

Merged
MasterPtato merged 1 commit intomainfrom
03-16-chore_improve_serverless_refresh_error
Mar 17, 2026
Merged

chore: improve serverless refresh error#4436
MasterPtato merged 1 commit intomainfrom
03-16-chore_improve_serverless_refresh_error

Conversation

@MasterPtato
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4436 March 16, 2026 23:34 Destroyed
@railway-app
Copy link

railway-app bot commented Mar 16, 2026

🚅 Deployed to the rivet-pr-4436 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Mar 16, 2026 at 11:47 pm
frontend-cloud 😴 Sleeping (View Logs) Web Mar 16, 2026 at 11:44 pm
frontend-inspector 😴 Sleeping (View Logs) Web Mar 16, 2026 at 11:41 pm
mcp-hub ✅ Success (View Logs) Web Mar 16, 2026 at 11:36 pm
ladle ❌ Build Failed (View Logs) Web Mar 16, 2026 at 11:35 pm

Copy link
Contributor Author

MasterPtato commented Mar 16, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MasterPtato MasterPtato mentioned this pull request Mar 16, 2026
11 tasks
@MasterPtato MasterPtato force-pushed the 03-16-chore_improve_serverless_refresh_error branch from fc4e0a5 to b4a3ace Compare March 16, 2026 23:36
@MasterPtato MasterPtato force-pushed the 03-13-fix_ignore_invalid_base64_input branch from 92af256 to ed101ee Compare March 16, 2026 23:36
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 16, 2026

More templates

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4436

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4436

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4436

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4436

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4436

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4436

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4436

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4436

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4436

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4436

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4436

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4436

commit: b4a3ace

@claude
Copy link

claude bot commented Mar 16, 2026

PR Review: chore: improve serverless refresh error. Small improvement promoting anyhow! to a typed RivetError. Bug: two-arg error macro treats second arg as static string, so the reason placeholder appears verbatim in default_message - needs a third arg for dynamic interpolation. Minor: ServerlessRunnerPool lacks Clone unlike Actor and Runner in the same file. Positives: removing unused anyhow import, cleaner await map_err chain, structured meta payload.

@claude
Copy link

claude bot commented Mar 16, 2026

PR Review: chore: improve serverless refresh error. Overall: Approved. Small, well-scoped improvement. Summary: (1) engine/packages/pegboard/src/errors.rs adds a new FailedToFetchMetadata variant to ServerlessRunnerPool wrapping ServerlessMetadataError. (2) engine/packages/api-public/src/runner_configs/utils.rs replaces a generic anyhow! string error with the typed ServerlessRunnerPool::FailedToFetchMetadata error, removes the unused anyhow::anyhow import, and renames result to metadata for clarity. What is good: Replacing an untyped anyhow! string with a structured RivetError variant is the correct pattern per conventions. The unused import is cleaned up. The variable rename improves readability. ServerlessMetadataError already derives Serialize, Deserialize, Clone, and Debug satisfying trait bounds for embedding in a RivetError variant. Minor observation: The new error uses debug formatting {reason:?} in the message template. ServerlessMetadataError does not implement Display so this produces verbose Rust debug output. Not a bug, but if user-facing consider implementing Display for ServerlessMetadataError and switching to {reason}. Asymmetry note: fetch_serverless_runner_metadata maps all ServerlessMetadataError variants to RequestFailed discarding the original variant, while refresh_runner_config_metadata preserves the full structured error. Appears intentional but worth confirming. No convention issues: correct use of derive(RivetError), no rivet.gg domains, no logging violations, no new raw anyhow! macros. No blocking issues found.

Copy link
Contributor Author

MasterPtato commented Mar 17, 2026

Merge activity

  • Mar 17, 1:28 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 17, 1:32 AM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 17, 1:32 AM UTC: @MasterPtato merged this pull request with Graphite.

@MasterPtato MasterPtato changed the base branch from 03-13-fix_ignore_invalid_base64_input to graphite-base/4436 March 17, 2026 01:28
@MasterPtato MasterPtato changed the base branch from graphite-base/4436 to main March 17, 2026 01:30
@MasterPtato MasterPtato force-pushed the 03-16-chore_improve_serverless_refresh_error branch from b4a3ace to 59396a4 Compare March 17, 2026 01:31
@MasterPtato MasterPtato merged commit e401587 into main Mar 17, 2026
11 of 12 checks passed
@MasterPtato MasterPtato deleted the 03-16-chore_improve_serverless_refresh_error branch March 17, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant