fix(engine): use proper paths for settings#4447
fix(engine): use proper paths for settings#4447jog1t wants to merge 1 commit into03-17-feat_frontend_add_outdated_indicator_to_runnersfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
🚅 Deployed to the rivet-pr-4447 environment in rivet-frontend
|
PR ReviewSummaryThis PR fixes frontend routing by renaming the engine settings route from What's Good
Issues / Feedback1. PR description is empty 2. Scope relative to PR title 3. Engine-mode ProviderDropdown behavior worth confirming 4. Draft status and downstack dependency No security or performance concerns. Overall this is a straightforward fix — main ask is to fill out the PR description and confirm the ProviderDropdown engine-mode behavior is intentional. |

Description
This change renames the engine route from
/connectto/settingsand enhances the sidebar navigation with improved visual design. The main changes include:connect.tsxtosettings.tsxand updated the route path from/ns/$namespace/connectto/ns/$namespace/settingsSubnavcomponent toEngineSubnavand restructured its layout to include a Settings link and improved spacingoutline/secondarytoghostType of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: