Skip to content

chore: sqlite launch (#4307)#4462

Merged
NathanFlurry merged 1 commit intomainfrom
NicholasKissel/rm-deploy-buttons
Mar 20, 2026
Merged

chore: sqlite launch (#4307)#4462
NathanFlurry merged 1 commit intomainfrom
NicholasKissel/rm-deploy-buttons

Conversation

@NicholasKissel
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4462 March 20, 2026 04:34 Destroyed
@railway-app
Copy link

railway-app bot commented Mar 20, 2026

🚅 Deployed to the rivet-pr-4462 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-cloud 😴 Sleeping (View Logs) Web Mar 20, 2026 at 5:39 am
frontend-inspector 😴 Sleeping (View Logs) Web Mar 20, 2026 at 4:46 am
website ❌ Build Failed (View Logs) Web Mar 20, 2026 at 4:37 am
mcp-hub ✅ Success (View Logs) Web Mar 20, 2026 at 4:35 am
ladle ❌ Build Failed (View Logs) Web Mar 20, 2026 at 4:35 am

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Mar 20, 2026

PR Review

This is a small UI polish PR with a few concerns worth addressing.

Accessibility Issue (important)

frontend/src/app/forms/stepper-form.tsx — icon-only buttons lack aria-label

The Previous and Next buttons are changed to icon-only (size="icon"), but no aria-label is added:

<Button type="button" variant="outline" size="icon" onClick={goToPrev}>
    <Icon icon={faArrowLeft} />
</Button>

Icon-only buttons must have aria-label attributes for screen readers, otherwise the button has no accessible name. Suggested fix:

<Button type="button" variant="outline" size="icon" onClick={goToPrev} aria-label="Previous step">
    <Icon icon={faArrowLeft} />
</Button>

<Button type="submit" size="icon" aria-label={isLastVisible ? "Finish" : "Next step"} ...>
    <Icon icon={faArrowRight} />
</Button>

UX Regression

Loss of "Finish" indicator: The previous code rendered step.next || (isLastVisible ? "Finish" : "Next") as the button text, which signaled to users when they were on the final step. An arrow icon alone doesn't communicate "this will complete the flow." Consider at minimum adding a tooltip or keeping the "Finish" label for the last step.

Loss of per-step button text customization: The step.next override mechanism is now silently ignored. If any existing steps define a custom next label (e.g., "Deploy", "Create"), those labels will no longer appear. Verify that no steps in the codebase currently use step.next.

Help Button Layout

The NeedHelpButton is moved from its own div (with flex justify-end mt-6) to inside the title div. This changes its layout context — previously it was a full-width flex row anchored to the right; now it's a sibling of the <h2>. Visually verify this renders correctly across all stepper contexts.

Minor Observations

  • Removing the "1-Click Deploy" badges from Vercel and Railway in deploy.ts is straightforward. No concerns.
  • The AgentPromptBanner copy update in getting-started.tsx is clear and accurate. No concerns.

Summary: The accessibility gap on icon-only buttons is the main issue that should be fixed before merging. The UX regression around "Finish" labeling is worth at least a deliberate decision.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 20, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4462

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4462

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4462

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4462

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4462

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4462

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4462

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4462

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4462

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4462

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4462

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4462

commit: 308b5d6

@NathanFlurry NathanFlurry merged commit 6a0aba8 into main Mar 20, 2026
14 of 20 checks passed
@NathanFlurry NathanFlurry deleted the NicholasKissel/rm-deploy-buttons branch March 20, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants