fix(frontend): require full config schema in onboarding backend step#4471
fix(frontend): require full config schema in onboarding backend step#4471
Conversation
|
🚅 Deployed to the rivet-pr-4471 environment in rivet-frontend
|
PR ReviewThis PR fixes a real bug (the union schema silently dropping fields) and migrates actor routing from Bugs1. Debug console.log(formState.errors, formState.isValid, watch());This will log to the browser console in production. Must be removed. 2. Actor input encoding breaks when The CBOR to JSON change removed the conditional guard: // Before
input: data.input ? btoa(String.fromCharCode(...cbor.encode(data.input))) : undefined,
// After
input: btoa(JSON.stringify(data.input)),When 3. Missing In the await Promise.all([
...(__APP_TYPE__ === "cloud" ? [...] : []),
dataProvider.engineAdminTokenQueryOptions(), // returns options object, not a Promise
]);
Code Quality4. Commented-out code ( The Rivet Compute provider card block is commented out with JSX comments spanning ~20 lines. Dead code should either be deleted or tracked in a ticket rather than left in as a comment. 5. Misleading variable name ( const firstActorId = actors.pages[0]?.actors?.[0]?.key;
// ...
actorKey: firstActorId,The variable is named 6. {actors.map((actor) => (
<ActorsListRow
key={actor.key} // actor.key might be undefinedIf 7. Missing newline at end of file ( The file ends without a trailing newline and has two consecutive blank lines before the Minor Observations
|
…for serverless providers
f762066 to
d90b246
Compare
Summary
{ success: true }when the health check succeeded.endpointand other config fields, silently skipping the runner config upsert inonPartialSubmit.Changes
deploymentSchema.pick({ success: true }).or(z.object({ ...fullShape }))withz.object({ ...fullShape })for the onboarding backend step schema.Testing
client.runnerConfigsUpsertis called and runner configs appear in the namespace after the health check succeeds.