Skip to content

fix(rivetkit): copy Buffer to Uint8Array in ensureUint8Array to fix .slice() semantics #4506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanFlurry merged 1 commit into from
Mar 25, 2026
Merged

fix(rivetkit): copy Buffer to Uint8Array in ensureUint8Array to fix .slice() semantics #4506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions rivetkit-typescript/packages/rivetkit/src/drivers/file-system/sqlite-runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,16 @@ export function ensureUint8Array(
fieldName: string,
): Uint8Array {
if (value instanceof Uint8Array) {
// Buffer (from better-sqlite3) extends Uint8Array but overrides
// .slice() to return a view instead of a copy. This breaks
// downstream libraries (vbare, cbor-x) that rely on
// Uint8Array.prototype.slice() semantics. Copy into a plain
// Uint8Array so .slice() always copies.
if (typeof Buffer !== "undefined" && Buffer.isBuffer(value)) {
const copy = new Uint8Array(value.byteLength);
copy.set(value);
return copy;
}
return value;
}
if (value instanceof ArrayBuffer) {
Expand Down
Loading