Revert "fix(rivetkit): gate node:sqlite behind RIVETKIT_NODE_SQLITE env var"#4508
Merged
NathanFlurry merged 1 commit intomainfrom Mar 26, 2026
Merged
Revert "fix(rivetkit): gate node:sqlite behind RIVETKIT_NODE_SQLITE env var"#4508NathanFlurry merged 1 commit intomainfrom
NathanFlurry merged 1 commit intomainfrom
Conversation
|
🚅 Deployed to the rivet-pr-4508 environment in rivet-frontend
|
This was referenced Mar 25, 2026
Member
Author
PR Review: Revert node:sqlite env var gate\n\n### Summary\n\nThis revert removes the RIVETKIT_NODE_SQLITE=1 opt-in gate and unconditionally attempts node:sqlite, while also removing the better-sqlite3 package as an explicit dependency.\n\n### Concerns\n\n1. Noisy experimental warning returns\n\nThe original fix suppressed the Node.js ExperimentalWarning: SQLite is an experimental feature and might change at any time that fires for all users on Node 22.x. This revert brings that warning back.\n\nIf the motivation is that node:sqlite graduated to stable in Node 23.4+, that is a valid reason but Node 22 is still the active LTS and users on it will see this warning on every actor startup. It would help to document the rationale in the PR description.\n\nOne middle ground worth considering: check the Node.js major/minor version and only use node:sqlite on 23.4+ (where it is stable), falling through to better-sqlite3 on older releases.\n\n2. better-sqlite3 removed from deps but still referenced in code\n\nbetter-sqlite3 was removed from package.json dependencies, but sqlite-runtime.ts lines 152-181 still try to load it as a fallback, and the runtime kind enum on line 3 still includes better-sqlite3. The fallback still works at runtime (the error message tells users to install it manually), but users on Node 22 who hit that path will encounter an unexplained failure unless they read the error carefully. This is a behavior regression compared to before the original fix.\n\n3. Empty PR description\n\nThe default PR template was not filled in. Since this is a revert of a deliberate fix (the original PR comment explained the tradeoff in detail), it would be helpful to explain why the original fix is being reverted.\n\n### Minor\n\nThe ensureUint8Array comment on line 212 still references from better-sqlite3 - accurate since it can still be loaded at runtime, just not bundled as an explicit dep. Fine as-is.\n\n### Verdict\n\nThe change itself is clean and minimal. The main risk is the regression of experimental warnings for Node 22 LTS users, combined with better-sqlite3 no longer being a bundled fallback. Clarifying the intent and Node version support expectations before merging would be helpful. |
ebeacb9 to
1a02e25
Compare
Member
Author
Merge activity
|
b08e139 to
7f5a607
Compare
1a02e25 to
7b43ac0
Compare
…nv var" This reverts commit d3ff710.
7b43ac0 to
99e1693
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: