Skip to content

Revert "fix(rivetkit): gate node:sqlite behind RIVETKIT_NODE_SQLITE env var"#4508

Merged
NathanFlurry merged 1 commit intomainfrom
03-25-revert_node_sqlite_gating
Mar 26, 2026
Merged

Revert "fix(rivetkit): gate node:sqlite behind RIVETKIT_NODE_SQLITE env var"#4508
NathanFlurry merged 1 commit intomainfrom
03-25-revert_node_sqlite_gating

Conversation

@NathanFlurry
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link

railway-app bot commented Mar 25, 2026

🚅 Deployed to the rivet-pr-4508 environment in rivet-frontend

Service Status Web Updated (UTC)
kitchen-sink ❌ Build Failed (View Logs) Web Mar 26, 2026 at 9:07 am
frontend-inspector ❌ Build Failed (View Logs) Web Mar 26, 2026 at 8:18 am
frontend-cloud ❌ Build Failed (View Logs) Web Mar 26, 2026 at 8:18 am
website 😴 Sleeping (View Logs) Web Mar 25, 2026 at 4:54 pm
ladle ❌ Build Failed (View Logs) Web Mar 25, 2026 at 4:44 pm
mcp-hub ✅ Success (View Logs) Web Mar 25, 2026 at 4:42 pm

@NathanFlurry NathanFlurry mentioned this pull request Mar 25, 2026
11 tasks
@claude
Copy link

claude bot commented Mar 25, 2026

PR Review: Revert node:sqlite env var gate\n\n### Summary\n\nThis revert removes the RIVETKIT_NODE_SQLITE=1 opt-in gate and unconditionally attempts node:sqlite, while also removing the better-sqlite3 package as an explicit dependency.\n\n### Concerns\n\n1. Noisy experimental warning returns\n\nThe original fix suppressed the Node.js ExperimentalWarning: SQLite is an experimental feature and might change at any time that fires for all users on Node 22.x. This revert brings that warning back.\n\nIf the motivation is that node:sqlite graduated to stable in Node 23.4+, that is a valid reason but Node 22 is still the active LTS and users on it will see this warning on every actor startup. It would help to document the rationale in the PR description.\n\nOne middle ground worth considering: check the Node.js major/minor version and only use node:sqlite on 23.4+ (where it is stable), falling through to better-sqlite3 on older releases.\n\n2. better-sqlite3 removed from deps but still referenced in code\n\nbetter-sqlite3 was removed from package.json dependencies, but sqlite-runtime.ts lines 152-181 still try to load it as a fallback, and the runtime kind enum on line 3 still includes better-sqlite3. The fallback still works at runtime (the error message tells users to install it manually), but users on Node 22 who hit that path will encounter an unexplained failure unless they read the error carefully. This is a behavior regression compared to before the original fix.\n\n3. Empty PR description\n\nThe default PR template was not filled in. Since this is a revert of a deliberate fix (the original PR comment explained the tradeoff in detail), it would be helpful to explain why the original fix is being reverted.\n\n### Minor\n\nThe ensureUint8Array comment on line 212 still references from better-sqlite3 - accurate since it can still be loaded at runtime, just not bundled as an explicit dep. Fine as-is.\n\n### Verdict\n\nThe change itself is clean and minimal. The main risk is the regression of experimental warnings for Node 22 LTS users, combined with better-sqlite3 no longer being a bundled fallback. Clarifying the intent and Node version support expectations before merging would be helpful.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 25, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4508

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4508

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4508

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4508

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4508

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4508

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4508

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4508

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4508

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4508

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4508

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4508

commit: 1a02e25

Copy link
Member Author

NathanFlurry commented Mar 25, 2026

Merge activity

  • Mar 25, 7:43 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 25, 8:13 PM UTC: Graphite couldn't merge this pull request because a downstack PR fix: correct stop codes #4507 failed to merge.
  • Mar 26, 9:05 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 26, 9:07 AM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 26, 9:07 AM UTC: @NathanFlurry merged this pull request with Graphite.

@NathanFlurry NathanFlurry changed the base branch from 03-25-fix_correct_stop_codes to graphite-base/4508 March 25, 2026 20:13
@NathanFlurry NathanFlurry force-pushed the 03-25-revert_node_sqlite_gating branch from 1a02e25 to 7b43ac0 Compare March 26, 2026 08:17
@NathanFlurry NathanFlurry changed the base branch from graphite-base/4508 to 03-25-fix_correct_stop_codes March 26, 2026 08:17
@NathanFlurry NathanFlurry changed the base branch from 03-25-fix_correct_stop_codes to graphite-base/4508 March 26, 2026 09:05
@NathanFlurry NathanFlurry changed the base branch from graphite-base/4508 to main March 26, 2026 09:05
@NathanFlurry NathanFlurry force-pushed the 03-25-revert_node_sqlite_gating branch from 7b43ac0 to 99e1693 Compare March 26, 2026 09:06
@NathanFlurry NathanFlurry merged commit 051400a into main Mar 26, 2026
14 of 20 checks passed
@NathanFlurry NathanFlurry deleted the 03-25-revert_node_sqlite_gating branch March 26, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant