Isolate postgres subscriber cleanup#4520
Merged
NathanFlurry merged 1 commit intorivet-dev:mainfrom Mar 27, 2026
Merged
Conversation
The Postgres pubsub driver shared one CancellationToken across all subscribers for a subject, so dropping one subscriber could tear down the subject for the others too. In runner mode this could surface as a false actor_stopped path and cause retries or duplicate execution. Give each subscriber its own cleanup task and DropGuard instead. Only UNLISTEN and remove the subject once the broadcast sender has no remaining receivers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Postgres pubsub driver shared one CancellationToken across all subscribers for a subject, so dropping one subscriber could tear down the subject for the others too. In runner mode this could surface as a false actor_stopped path and cause retries or duplicate execution.
Give each subscriber its own cleanup task and DropGuard instead. Only UNLISTEN and remove the subject once the broadcast sender has no remaining receivers.
Fixes: #4519