You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more
Overall this is a clean housekeeping PR. A few notes:
lefthook.yml — Lockfile enforcement
The two new hooks are a good addition. A couple of observations:
pnpm install --frozen-lockfile --ignore-scripts will do a full package graph resolution on every commit. For contributors with a warm pnpm cache this is fast, but on a cold environment (CI machine, fresh clone) it can be slow. Consider adding a glob filter so the hook only fires when package.json or pnpm-lock.yaml are among the staged files, e.g.:
@rivetkit/sqlite-vfs added: The lockfile now includes a new rivetkit-typescript/packages/sqlite-vfs importer with @rivetkit/sqlite@0.1.1 as a dependency. CLAUDE.md explicitly calls out: "do not add @rivetkit/sqlite, @rivetkit/sqlite-vfs, or other WebAssembly SQLite fallbacks." Is this package intentional and exempt from that guidance, or inadvertently included?
jiti downgrade (2.6.1 → 1.21.7): jiti v2 is a significant rework of v1. If this is an intentional pin to v1 (e.g., to fix a compatibility issue), it would be worth a brief note in the PR description so future bumps don't silently re-introduce the issue.
@rivetkit/engine-api-full switched to workspace:*: Good — removes the dependency on an external PR-preview package.
Cargo.toml
Removing the stale rivetkit-sqlite-native workspace path declaration is clean.
database.rs
Indentation fix looks correct.
Summary: No blocking issues, but the sqlite-vfs inclusion and jiti downgrade are worth a brief explanation. The glob-filter suggestion for the pre-commit hooks is optional but would help on cold setups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: