Skip to content

chore: lockfile lefthook#4647

Draft
NathanFlurry wants to merge 1 commit intofix/surface-native-sqlite-kv-errorsfrom
04-13-chore_lockfile_lefthook
Draft

chore: lockfile lefthook#4647
NathanFlurry wants to merge 1 commit intofix/surface-native-sqlite-kv-errorsfrom
04-13-chore_lockfile_lefthook

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown

claude bot commented Apr 13, 2026

PR Review

Overall this is a clean housekeeping PR. A few notes:

lefthook.yml — Lockfile enforcement

The two new hooks are a good addition. A couple of observations:

  • pnpm install --frozen-lockfile --ignore-scripts will do a full package graph resolution on every commit. For contributors with a warm pnpm cache this is fast, but on a cold environment (CI machine, fresh clone) it can be slow. Consider adding a glob filter so the hook only fires when package.json or pnpm-lock.yaml are among the staged files, e.g.:

    pnpm-lock:
      glob: '{package.json,pnpm-lock.yaml,**/package.json}'
      run: pnpm install --frozen-lockfile --ignore-scripts
      tags: lockfile

    Same idea applies to cargo-lock with a Cargo.{toml,lock} glob.

  • cargo metadata --locked --no-deps >/dev/null — solid approach; --no-deps keeps it fast.

pnpm-lock.yaml

  • @rivetkit/sqlite-vfs added: The lockfile now includes a new rivetkit-typescript/packages/sqlite-vfs importer with @rivetkit/sqlite@0.1.1 as a dependency. CLAUDE.md explicitly calls out: "do not add @rivetkit/sqlite, @rivetkit/sqlite-vfs, or other WebAssembly SQLite fallbacks." Is this package intentional and exempt from that guidance, or inadvertently included?

  • jiti downgrade (2.6.1 → 1.21.7): jiti v2 is a significant rework of v1. If this is an intentional pin to v1 (e.g., to fix a compatibility issue), it would be worth a brief note in the PR description so future bumps don't silently re-introduce the issue.

  • @rivetkit/engine-api-full switched to workspace:*: Good — removes the dependency on an external PR-preview package.

Cargo.toml

Removing the stale rivetkit-sqlite-native workspace path declaration is clean.

database.rs

Indentation fix looks correct.


Summary: No blocking issues, but the sqlite-vfs inclusion and jiti downgrade are worth a brief explanation. The glob-filter suggestion for the pre-commit hooks is optional but would help on cold setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant