feat(frontend): add enoys to the runner table#4675
feat(frontend): add enoys to the runner table#4675jog1t wants to merge 1 commit into04-14-refactor_frontend_support_envoysfrom
Conversation
|
🚅 Deployed to the rivet-pr-4675 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: Add Envoys to the Runner TableSummaryThis PR adds Envoy entries alongside Runners in the settings table view, with supporting data fetching and type-safe rendering. Overall the approach is sound, but there are a few issues worth addressing. IssuesPagination logic is broken (Medium)File: The fetchNextPage={() => {
if (hasNextEnvoysPage) fetchNextEnvoysPage();
if (hasNextPage) fetchNextPage();
}}This fires both fetches simultaneously on every click, rather than coordinating them. If envoys have 2 pages and runners have 1, the second click will attempt to fetch a runners page that doesn't exist. Consider tracking the two queries separately or using a combined cursor strategy. Dead code (Low)File:
Unrelated change needs context (Low)File: Step 3 ("Wait for the Runner to connect") is removed with no explanation. This appears unrelated to the envoy feature. If this is intentional (e.g., runners now auto-connect), a comment or PR note explaining why would help reviewers and future readers. Missing memoizationFile: allRunners = [...envoys, ...runners]This array is recreated on every render. Wrapping in Positive Notes
Test CoverageNo tests cover the combined Runner+Envoy rendering path or the pagination coordination logic. Given the pagination issue above, a test for the load-more behavior with mixed data would be valuable. |
6a878b9 to
d9492e3
Compare
597599a to
b34ac38
Compare
Preview packages published to npmInstall with: npm install rivetkit@pr-4675All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-c03f935
docker pull rivetdev/engine:full-c03f935Individual packagesnpm install rivetkit@pr-4675
npm install @rivetkit/react@pr-4675
npm install @rivetkit/rivetkit-native@pr-4675
npm install @rivetkit/sqlite-wasm@pr-4675
npm install @rivetkit/workflow-engine@pr-4675 |
Code ReviewThis PR adds Envoy entries to the Runners table, extends metadata parsing, and removes a dialog step. Issues:
Minor notes:
What looks good:
|

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: