refactor(frontend): improve "go to actor" ux#4682
Conversation
|
🚅 Deployed to the rivet-pr-4682 environment in rivet-frontend
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Code ReviewOverall this is a solid UX improvement. The inline input replacing the modal dialog is a more direct interaction pattern. A few issues worth addressing before merging: Bugs / CorrectnessDouble-submit on Enter + blur ( When a user presses Enter, Guard const handleKeyDown = (e: React.KeyboardEvent<HTMLInputElement>) => {
if (e.key === "Enter") {
e.preventDefault(); // prevent blur-triggered submit
void handleSubmit();
}
if (e.key === "Escape") {
setValue("");
setOpen(false);
}
};
// then in JSX:
onBlur={() => { if (!isPending) void handleSubmit(); }}
The Silent fallback hides non-404 errors from the user In Unused Code (
|
Preview packages published to npmInstall with: npm install rivetkit@pr-4682All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-eca8092
docker pull rivetdev/engine:full-eca8092Individual packagesnpm install rivetkit@pr-4682
npm install @rivetkit/react@pr-4682
npm install @rivetkit/rivetkit-native@pr-4682
npm install @rivetkit/sqlite-wasm@pr-4682
npm install @rivetkit/workflow-engine@pr-4682 |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: