Skip to content

fix(cors): use explicit header allowlist fallback instead of wildcard #4965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abcxff wants to merge 1 commit into
base: abc-2.2.1-patch
Choose a base branch
from
+6 −1
Open

fix(cors): use explicit header allowlist fallback instead of wildcard #4965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rivetkit-typescript/packages/rivetkit/src/common/actor-router-consts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export const WS_TEST_PROTOCOL_PATH = "test_path.";
* Used for CORS.
**/
export const ALLOWED_PUBLIC_HEADERS = [
"Authorization",
"Content-Type",
"User-Agent",
HEADER_ACTOR_QUERY,
Expand Down
6 changes: 5 additions & 1 deletion rivetkit-typescript/packages/rivetkit/src/common/cors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
import type { MiddlewareHandler } from "hono";
import { ALLOWED_PUBLIC_HEADERS } from "@/common/actor-router-consts";

const DEFAULT_ALLOWED_HEADERS = ALLOWED_PUBLIC_HEADERS.join(", ");

/**
* Simple CORS middleware that matches the gateway behavior.
Expand All @@ -18,7 +21,8 @@ export const cors = (): MiddlewareHandler => {
// Handle preflight OPTIONS request
if (c.req.method === "OPTIONS") {
const requestHeaders =
c.req.header("access-control-request-headers") || "*";
c.req.header("access-control-request-headers") ??
DEFAULT_ALLOWED_HEADERS;

c.header("access-control-allow-origin", origin);
c.header("access-control-allow-credentials", "true");
Expand Down
Loading