fix(frontend): missing skeleton view for actor names

[jog1t]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[jog1t]

• refactor(frontend): sleep/schedule/wake actions on actors #5092
• refactor(frontend): bring back the billing gauge #5091
• fix(frontend): remove create actor from context switcher #5090
• fix(frontend): dark mode issues on health check monitor #5088
• fix(frontend): custom actor icons not displaying #5083
• refactor(frontend): unify settings pages #5082
• fix(frontend): re-layout members screen #5081
• fix(frontend): navigation during open popover breaks closing animation #5080
• fix(frontend): hover animation on project cards not moving billing badge #5079
• fix(frontend): missing skeleton view for actor names #5078 👈 (View in Graphite)
• fix(frontend): ensure onboarding checks are only for production namespace, improve caching #5077
• fix(frontend): fix changelog display #5076
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: fix(frontend): missing skeleton view for actor names

This is a clean, focused fix that adds a proper loading skeleton state to the actors grid. The change is small and well-scoped. Since the PR is already merged, this is a retrospective review.

---

What the change does

• Adds an ActorGridCardSkeleton component that mirrors the dimensions/styling of the real GridCard
• Adds delayMs? to the MSW mock utility so loading states can be inspected during dev/testing
• Updates CLAUDE.md with a usage example for the new mock option

---

Looks good

Skeleton structure: The skeleton card correctly mirrors the real card shape (min-h-[110px], icon placeholder + two text lines), which avoids layout shift when content loads in.

Render logic: The three-branch ternary (isLoading → skeleton, builds.length === 0 → empty state, otherwise → grid) correctly handles all cases. Previously the component silently rendered nothing during load.

Biome ignore comment: // biome-ignore lint/suspicious/noArrayIndexKey: skeleton loaders are static is the right call. Index keys are safe here because skeleton items are statically ordered and never reordered.

delayMs implementation: Making buildHandler async and conditionally awaiting delay(m.delayMs) before returning is clean. The if (m.delayMs) guard correctly skips the delay when unset or zero.

---

Minor observations

Hardcoded skeleton count (8): Rendering exactly 8 skeletons regardless of actual actor count is standard practice and fine, but worth noting if the typical actor count is much smaller — users may see more skeleton cards than real cards appear. Not a bug, just a style choice.

Grid column consistency: The skeleton grid uses grid-cols-2 sm:grid-cols-3 md:grid-cols-4 gap-3. If the actual content grid uses different responsive breakpoints, there will be a layout shift on load completion. Worth a spot-check against the real builds grid layout if not already verified visually.

No error-state divergence: The diff doesn't show how isLoading is set to false on query error. If a failed fetch leaves isLoading: false and builds: [], the empty-state fallback renders, which is correct. Just confirming that path is covered.

---

Summary

Solid, minimal fix. The skeleton component is well-structured and the mock utility enhancement is a useful developer tool. No blocking issues.

[jog1t]

Merge activity

• May 21, 8:51 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• May 21, 8:55 PM UTC: Graphite rebased this pull request as part of a merge.
• May 21, 8:55 PM UTC: @jog1t merged this pull request with Graphite.