Skip to content

fix: get rid of old hub.rivet.dev references#5123

Open
abcxff wants to merge 1 commit into
06-02-fix_frontend_onboarding_promptsfrom
06-02-fix_get_rid_of_old_hub.rivet.dev_references
Open

fix: get rid of old hub.rivet.dev references#5123
abcxff wants to merge 1 commit into
06-02-fix_frontend_onboarding_promptsfrom
06-02-fix_get_rid_of_old_hub.rivet.dev_references

Conversation

@abcxff
Copy link
Copy Markdown
Contributor

@abcxff abcxff commented Jun 2, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Contributor Author

abcxff commented Jun 2, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@abcxff abcxff force-pushed the 06-02-fix_frontend_onboarding_prompts branch from 310086b to a3735c0 Compare June 2, 2026 19:39
@abcxff abcxff force-pushed the 06-02-fix_get_rid_of_old_hub.rivet.dev_references branch from 970b31e to 36601dd Compare June 2, 2026 19:39
@railway-app
Copy link
Copy Markdown

railway-app Bot commented Jun 2, 2026

🚅 Deployed to the rivet-pr-5123 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Jun 3, 2026 at 1:58 pm
frontend-cloud 😴 Sleeping (View Logs) Web Jun 3, 2026 at 12:41 pm
ladle ✅ Success (View Logs) Web Jun 2, 2026 at 7:44 pm
mcp-hub ✅ Success (View Logs) Web Jun 2, 2026 at 7:42 pm
frontend-inspector ❌ Build Failed (View Logs) Web Jun 2, 2026 at 7:41 pm
kitchen-sink ❌ Build Failed (View Logs) Web Jun 2, 2026 at 7:40 pm

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Jun 2, 2026

Code Review

Summary: This PR replaces 16 occurrences of hub.rivet.dev with dashboard.rivet.dev across documentation, examples, and one commented-out line in utils.ts. No production logic is changed.

Findings

Incomplete coverage — stale references in .agents/skills/

Four files in the checked-in skill reference cache still point to the old URL:

.agents/skills/multiplayer-game/reference/connect/cloudflare.md
.agents/skills/multiplayer-game/reference/connect/supabase.md
.agents/skills/rivetkit/reference/connect/cloudflare.md
.agents/skills/rivetkit/reference/connect/supabase.md

These are cached copies from the external rivet-dev/skills repo (skills-lock.json lists them). They are loaded into AI agent context and would point users to the old URL. The fix likely needs to land in rivet-dev/skills first and then be re-locked here, but it is worth tracking.

Dead commented-out code in utils.ts:138

The updated line is inside a block that has been commented out since it was introduced. Keeping the URL current in dead code is unnecessary maintenance. If the URL was never meant to ship, the comment block should be deleted outright.


No other hub.rivet.dev references found in *.md, *.mdx, *.ts, *.tsx, *.js, *.json, *.yaml, *.toml, or *.rs files outside the .agents/ cache. No behavioral or security changes.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Jun 2, 2026

PR Review: fix: get rid of old hub.rivet.dev references

Status: Draft | Files changed: 11 | Lines: +16 / -16

Summary

Pure URL reference update replacing hub.rivet.dev with dashboard.rivet.dev across documentation, examples, and one source file. All in-scope substitutions are correct and the diff is clean.


Missed References

The PR does not update four .agents/skills/ reference files that still contain the old URL:

  • .agents/skills/multiplayer-game/reference/connect/cloudflare.md (line 16)
  • .agents/skills/multiplayer-game/reference/connect/supabase.md (line 16)
  • .agents/skills/rivetkit/reference/connect/cloudflare.md (line 16)
  • .agents/skills/rivetkit/reference/connect/supabase.md (line 16)

Each contains:

- A Rivet namespace from the [Rivet Dashboard](https://hub.rivet.dev/) or a self-hosted Rivet Engine

These appear to mirror the canonical website docs under website/src/content/docs/connect/ that were updated in this PR. They should be updated to dashboard.rivet.dev in the same change.


Other Observations

  • The change to rivetkit-typescript/packages/rivetkit/src/common/utils.ts updates only a commented-out URL — no runtime impact, but correct to update.
  • No bugs, security, or performance concerns. This is a mechanical string replacement.
  • No tests needed for this type of change.

Verdict

LGTM once the four .agents/skills/ reference files are updated.

@abcxff abcxff marked this pull request as ready for review June 2, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants