You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary: This PR fixes a missing import for getRivetRunUrl that would have caused a ReferenceError at runtime. The ternary reformatting is also a nice readability improvement.
Issue: Duplicate import from the same module
The new import uses a relative path while the existing import from the same file already uses the @/ alias. Both resolve to the same file (frontend/src/lib/env.ts). The fix should consolidate these into a single import:
Existing: import { cloudEnv } from "@/lib/env";
New: import { getRivetRunUrl } from "../lib/env";
Should be: import { cloudEnv, getRivetRunUrl } from "@/lib/env";
This matches the @/ alias convention used by every other import in this file and avoids two separate imports from the same module.
Everything else looks good - the bug fix is real (missing import would throw at runtime) and the ternary reformatting improves readability with no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: