Skip to content

fix(frontend): getRivetRunUrl import#5176

Merged
abcxff merged 1 commit into
mainfrom
06-05-fix_frontend_getrivetrunurl_import
Jun 5, 2026
Merged

fix(frontend): getRivetRunUrl import#5176
abcxff merged 1 commit into
mainfrom
06-05-fix_frontend_getrivetrunurl_import

Conversation

@abcxff
Copy link
Copy Markdown
Contributor

@abcxff abcxff commented Jun 5, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5176 June 5, 2026 20:46 Destroyed
@railway-app
Copy link
Copy Markdown

railway-app Bot commented Jun 5, 2026

🚅 Deployed to the rivet-pr-5176 environment in rivet-frontend

Service Status Web Updated (UTC)
ladle ✅ Success (View Logs) Web Jun 5, 2026 at 8:49 pm
frontend-cloud ✅ Success (View Logs) Web Jun 5, 2026 at 8:49 pm
kitchen-sink ❌ Build Failed (View Logs) Web Jun 5, 2026 at 8:48 pm
mcp-hub ✅ Success (View Logs) Web Jun 5, 2026 at 8:48 pm
website ✅ Success (View Logs) Web Jun 5, 2026 at 8:48 pm
frontend-inspector ❌ Build Failed (View Logs) Web Jun 5, 2026 at 8:47 pm

Copy link
Copy Markdown
Contributor Author

abcxff commented Jun 5, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@abcxff abcxff marked this pull request as ready for review June 5, 2026 20:47
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Jun 5, 2026

Code Review

Summary: This PR fixes a missing import for getRivetRunUrl that would have caused a ReferenceError at runtime. The ternary reformatting is also a nice readability improvement.

Issue: Duplicate import from the same module

The new import uses a relative path while the existing import from the same file already uses the @/ alias. Both resolve to the same file (frontend/src/lib/env.ts). The fix should consolidate these into a single import:

Existing: import { cloudEnv } from "@/lib/env";
New: import { getRivetRunUrl } from "../lib/env";

Should be: import { cloudEnv, getRivetRunUrl } from "@/lib/env";

This matches the @/ alias convention used by every other import in this file and avoids two separate imports from the same module.

Everything else looks good - the bug fix is real (missing import would throw at runtime) and the ternary reformatting improves readability with no behavior change.

@abcxff abcxff merged commit 62f5e61 into main Jun 5, 2026
12 of 17 checks passed
@abcxff abcxff deleted the 06-05-fix_frontend_getrivetrunurl_import branch June 5, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant