Skip to content

fix(frontend): render version_check workflow entries with icon and summary#5368

Merged
abcxff merged 2 commits into
mainfrom
stack/fix-frontend-render-version_check-workflow-entries-with-icon-and-summary-oprtsksx
Jul 4, 2026
Merged

fix(frontend): render version_check workflow entries with icon and summary#5368
abcxff merged 2 commits into
mainfrom
stack/fix-frontend-render-version_check-workflow-entries-with-icon-and-summary-oprtsksx

Conversation

@abcxff

@abcxff abcxff commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@abcxff

abcxff commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Stack for rivet-dev/rivet

Get stack: forklift get 5368
Push local edits: forklift submit
Merge when ready: forklift merge 5368

change oprtsksx

@claude

claude Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review

Small, focused fix that fills in the gap left by transform-workflow-history.ts already emitting "version_check" entries (via WorkflowVersionCheckEntry) with no corresponding icon/summary rendering. Before this change those nodes silently fell through to the generic checkmark icon and an empty summary. The three edits (icon, summary, story) are consistent with the existing pattern for every other entry kind in these files.

Minor: stale duplicate type in workflow-visualizer.tsx

workflow-visualizer.tsx declares its own local MetaExtendedEntryType (around lines 37-47) instead of importing the one from xyflow-nodes.tsx, and it was not updated to include "version_check" in this PR:

type MetaExtendedEntryType =
	| "step"
	| "loop"
	| "sleep"
	| "message"
	| "rollback_checkpoint"
	| "join"
	| "race"
	| "try"
	| "removed"
	| "input"
	| "output";

This is used to cast selectedNode.entryType before indexing TYPE_COLORS and calling TypeIcon (both of which do handle version_check correctly now, since they use the real, imported type). Because the local union is a subset of the imported one, TS structurally allows the cast without complaint, so nothing breaks at runtime. But the type is now misleading/incomplete, and this kind of duplication is exactly what caused this PR to be needed in the first place: a variant added in one place, forgotten in another. Worth either adding "version_check" here too or importing MetaExtendedEntryType from xyflow-nodes.tsx instead of re-declaring it locally.

Nit: latest field unused in the summary

VersionCheckEntry carries both resolved and latest, but the summary only surfaces resolved (v${resolved}). If resolved !== latest is a meaningful state, such as an actor running an outdated version, it might be worth surfacing that in the summary or icon color rather than only in the raw-data inspector. Not a blocker, just a possible follow-up.

Everything else looks good

  • faTag is already used elsewhere in the codebase, so the new icon import is valid and consistent.
  • The new Ladle story follows the exact pattern of the sibling per-node-type stories already in this file.
  • No test coverage concerns beyond the story, since this is pure presentational mapping logic with no branching worth unit testing.

No security or performance concerns. This is presentation-only code operating on already-validated data.

@abcxff abcxff force-pushed the stack/feat-workflow-engine-add-getversion-primitive-for-workflow-versioning-wpnprqor branch from 106f329 to 889bd77 Compare July 4, 2026 03:31
@abcxff abcxff force-pushed the stack/fix-frontend-render-version_check-workflow-entries-with-icon-and-summary-oprtsksx branch from b9680eb to 1ed09c7 Compare July 4, 2026 03:31
@abcxff abcxff changed the base branch from stack/feat-workflow-engine-add-getversion-primitive-for-workflow-versioning-wpnprqor to main July 4, 2026 03:59
@abcxff abcxff merged commit 1ed09c7 into main Jul 4, 2026
8 of 19 checks passed
@abcxff abcxff deleted the stack/fix-frontend-render-version_check-workflow-entries-with-icon-and-summary-oprtsksx branch July 4, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant