Skip to content

fix: only select primary hostname in mm endpoints #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix: only select primary hostname in mm endpoints #577

merged 1 commit into from
Mar 22, 2024

Conversation

@MasterPtato
Copy link
Contributor

@MasterPtato MasterPtato commented Mar 21, 2024 •
edited
Loading

Fixes RVT-3691

Changes

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 21, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented Mar 21, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on Graphite Graphite

@linear
Copy link

linear bot commented Mar 21, 2024

RVT-3691 Add safeguard to ensure the correct hostname is getting returned from the matchmaker

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 22, 2024 •
edited
Loading

Merge activity

  • Mar 22, 2:39 PM EDT: NathanFlurry added this pull request to the Graphite merge queue.
  • Mar 22, 3:12 PM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (PR does not have required approvals).
  • Mar 22, 3:16 PM EDT: NathanFlurry added this pull request to the Graphite merge queue.
  • Mar 22, 3:17 PM EDT: NathanFlurry merged this pull request with the Graphite merge queue.

@MasterPtato
fix: only select primary hostname in mm endpoints (#577)
3d8e55d 
<!-- Please make sure there is an issue that this PR is correlated to. -->
Fixes RVT-3691
## Changes

<!-- If there are frontend changes, please include screenshots. -->
@NathanFlurry NathanFlurry force-pushed the 03-21-fix_only_select_primary_hostname_in_mm_endpoints branch from eb2902a to 3d8e55d Compare March 22, 2024 18:40
@graphite-app graphite-app bot merged commit 3d8e55d into main Mar 22, 2024
@github-actions github-actions bot mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanFlurry NathanFlurry NathanFlurry approved these changes

@AngelOnFira AngelOnFira Awaiting requested review from AngelOnFira

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MasterPtato @NathanFlurry