Skip to content

feat: add internal api monolith #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2024
Merged

feat: add internal api monolith #641

merged 1 commit into from
Apr 17, 2024

Conversation

@MasterPtato
Copy link
Contributor

@MasterPtato MasterPtato commented Apr 8, 2024

Changes

This was referenced Apr 8, 2024
Merged
Merged
Merged
@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented Apr 8, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on Graphite Graphite

NathanFlurry
NathanFlurry requested changes Apr 8, 2024
View reviewed changes
Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to be backwards compatible to support gg nodes with the old request config still on it.

this includes both:

  • the hostsni route
  • the path

tbh we could rename it to api-traefik to keep the path consistent for now.

@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented Apr 9, 2024 •
edited
Loading

@NathanFlurry Could you elaborate? There are no old gg nodes, you can't migrate from the old pools to new server provisioning

@MasterPtato MasterPtato requested a review from NathanFlurry April 9, 2024 00:17
@MasterPtato MasterPtato force-pushed the 04-03-feat_dynamic_TLS_generation branch from d1ca7c7 to d020e4c Compare April 12, 2024 00:15
@MasterPtato MasterPtato force-pushed the 04-08-feat_add_internal_api_monolith branch from ec8e42a to 6207c9d Compare April 12, 2024 00:15
This was referenced Apr 12, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@MasterPtato MasterPtato force-pushed the 04-03-feat_dynamic_TLS_generation branch from d020e4c to f7a4aaa Compare April 12, 2024 23:36
@MasterPtato MasterPtato force-pushed the 04-08-feat_add_internal_api_monolith branch from 6207c9d to 292478a Compare April 12, 2024 23:36
This was referenced Apr 12, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@NathanFlurry Graphite App
Copy link
Member

NathanFlurry commented Apr 15, 2024

@NathanFlurry Could you elaborate? There are no old gg nodes, you can't migrate from the old pools to new server provisioning

Ah right, my bad.

Since we're reworking this in this PR, can we rename api-route to api-traefik-provider? so the full route is just/traefik-provider/config (instead of /route/traefik/config). i think it's clearer what it actually does.

@MasterPtato MasterPtato force-pushed the 04-03-feat_dynamic_TLS_generation branch from 891f3b1 to 281f968 Compare April 15, 2024 21:42
@MasterPtato MasterPtato force-pushed the 04-08-feat_add_internal_api_monolith branch from 8ce9ff6 to 54cfeeb Compare April 15, 2024 21:42
@MasterPtato MasterPtato force-pushed the 04-03-feat_dynamic_TLS_generation branch from 281f968 to 80cfc06 Compare April 15, 2024 21:56
@MasterPtato MasterPtato force-pushed the 04-08-feat_add_internal_api_monolith branch from 54cfeeb to 183faad Compare April 15, 2024 21:56
@MasterPtato MasterPtato force-pushed the 04-03-feat_dynamic_TLS_generation branch from 80cfc06 to f7ca7f0 Compare April 16, 2024 00:08
@MasterPtato MasterPtato force-pushed the 04-08-feat_add_internal_api_monolith branch from 183faad to 1a5453f Compare April 16, 2024 00:08
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 17, 2024 •
edited
Loading

Merge activity

@MasterPtato
feat: add internal api monolith (#641)
f25ffe4 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@MasterPtato MasterPtato force-pushed the 04-03-feat_dynamic_TLS_generation branch from f7ca7f0 to 66e49dd Compare April 17, 2024 19:43
@MasterPtato MasterPtato force-pushed the 04-08-feat_add_internal_api_monolith branch from 1a5453f to f25ffe4 Compare April 17, 2024 19:44
@MasterPtato MasterPtato changed the base branch from 04-03-feat_dynamic_TLS_generation to main April 17, 2024 20:17
@graphite-app graphite-app bot merged commit f25ffe4 into main Apr 17, 2024
@graphite-app graphite-app bot deleted the 04-08-feat_add_internal_api_monolith branch April 17, 2024 20:21
@github-actions github-actions bot mentioned this pull request Apr 17, 2024
Merged
This was referenced Apr 17, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 19, 2024
Merged
Merged
This was referenced Apr 22, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanFlurry NathanFlurry NathanFlurry approved these changes

@AngelOnFira AngelOnFira Awaiting requested review from AngelOnFira

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MasterPtato @NathanFlurry