Skip to content

feat: add operation to list all clusters #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2024
Merged

feat: add operation to list all clusters #717

merged 1 commit into from
Apr 21, 2024

Conversation

@AngelOnFira
Copy link
Contributor

@AngelOnFira AngelOnFira commented Apr 19, 2024

Changes

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 19, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

This was referenced Apr 19, 2024
Merged
Merged
Merged
Merged
Closed
Closed
Merged
@AngelOnFira Graphite App
Copy link
Contributor Author

AngelOnFira commented Apr 19, 2024 •
edited by MasterPtato
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AngelOnFira and the rest of your teammates on Graphite Graphite

@AngelOnFira AngelOnFira mentioned this pull request Apr 19, 2024
Merged
@AngelOnFira AngelOnFira marked this pull request as ready for review April 19, 2024 04:11
@AngelOnFira AngelOnFira force-pushed the 04-19-feat_add_operation_to_list_all_clusters branch from 27f1de1 to 26911c8 Compare April 19, 2024 05:27
@AngelOnFira AngelOnFira force-pushed the 04-09-docs_fern_installation_instructions_for_script branch from d4ec784 to 1152d87 Compare April 19, 2024 13:06
@AngelOnFira AngelOnFira force-pushed the 04-19-feat_add_operation_to_list_all_clusters branch from 26911c8 to 081ed24 Compare April 19, 2024 13:06
@AngelOnFira AngelOnFira force-pushed the 04-09-docs_fern_installation_instructions_for_script branch from 1152d87 to e07ddb3 Compare April 19, 2024 13:34
@AngelOnFira AngelOnFira changed the base branch from 04-09-docs_fern_installation_instructions_for_script to main April 19, 2024 13:49
@AngelOnFira AngelOnFira force-pushed the 04-19-feat_add_operation_to_list_all_clusters branch 4 times, most recently from ed5d04e to f2343ed Compare April 19, 2024 15:59
MasterPtato
MasterPtato reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@MasterPtato MasterPtato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this operation going to be used for?

@AngelOnFira Graphite App
Copy link
Contributor Author

AngelOnFira commented Apr 19, 2024

What is this operation going to be used for?

It seems like the way to go is to do as much on the api consumer (bolt in this case) as possible. As such, there needs to be a way to convert from the name_id that is given from the CLI to a cluster_id, and instead of making 2 api calls, it would be better to make a single one that gets all the clusters, and let the client find the one it needs itself.

I was chatting with @NathanFlurry about this, and the idea is putting as much of the logic on the client side as possible. But if this doesn't seem right, I can check out a different way of going about it.

@AngelOnFira AngelOnFira force-pushed the 04-19-feat_add_operation_to_list_all_clusters branch from f2343ed to 83192e4 Compare April 20, 2024 18:30
This was referenced Apr 20, 2024
Merged
Closed
@AngelOnFira AngelOnFira force-pushed the 04-19-feat_add_operation_to_list_all_clusters branch from 83192e4 to 4bdfefc Compare April 21, 2024 00:12
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 21, 2024 •
edited
Loading

Merge activity

@AngelOnFira
feat: add operation to list all clusters (#717)
1f4b169 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@AngelOnFira AngelOnFira force-pushed the 04-19-feat_add_operation_to_list_all_clusters branch from 4bdfefc to 1f4b169 Compare April 21, 2024 00:18
@graphite-app graphite-app bot merged commit 1f4b169 into main Apr 21, 2024
@graphite-app graphite-app bot deleted the 04-19-feat_add_operation_to_list_all_clusters branch April 21, 2024 00:22
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
Merged
This was referenced Apr 22, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MasterPtato MasterPtato MasterPtato left review comments

@NathanFlurry NathanFlurry NathanFlurry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AngelOnFira @NathanFlurry @MasterPtato