chore: make startup logs easier to read

[NathanFlurry]

No description provided.

[claude]

Claude finished @NathanFlurry's task —— View job

---

Code Review Complete ✅

Todo List:

• Read and analyze changed files
• Review code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Assess security concerns
• Review test coverage impact
• Provide comprehensive feedback

---

Review Summary

This PR improves startup logging readability through three focused changes. The changes are well-implemented and follow good practices.

✅ Code Quality & Best Practices

• Consistent terminology: Changed actors → instances in extraStartupLog() (packages/core/src/drivers/file-system/manager.ts:298) provides clearer meaning
• Improved log messaging: "rivetkit started" → "rivetkit ready" is more descriptive and consistent
• Better separation of concerns: Studio logging split into conditional separate message
• Enhanced information: Added definitions count showing number of actor definitions registered

✅ No Bugs or Issues Found

• Property name change from actors to instances is cosmetic and safe
• Studio conditional logging properly checks config.studio?.enabled
• All changes maintain existing functionality while improving readability

✅ Performance Considerations

• Minimal performance impact - these are startup-time logging changes only
• Object.keys(this.#config.use).length runs once at startup, negligible cost
• No runtime performance regressions

✅ Security Assessment

• No security concerns introduced
• Studio URL logging remains properly conditional
• No sensitive data exposure in logs

✅ Test Coverage Impact

• Search confirmed no tests rely on old log message formats
• Test file updated appropriately (packages/core/src/test/mod.ts:54)
• Changes won't break existing test suites

Specific Changes Reviewed:

1. Manager Driver (packages/core/src/drivers/file-system/manager.ts:298):

   - actors: this.#state.actorCountOnStartup,
   + instances: this.#state.actorCountOnStartup,

2. Registry Module (packages/core/src/registry/mod.ts:72-81):

   - logger().info("rivetkit started", {
   + logger().info("rivetkit ready", {
       driver: config.driver.name,
   -   studio: getStudioUrl(config),
   +   definitions: Object.keys(this.#config.use).length,
       ...driverLog,
   });
   + if (config.studio?.enabled) {
   +   logger().info("studio ready", {
   +     url: getStudioUrl(config),
   +   });
   + }

3. Test Module (packages/core/src/test/mod.ts:54):

   - studio: getStudioUrl(config),
   + definitions: Object.keys(registry.config.use).length,

Recommendation: ✅ APPROVE

This is a well-executed chore that improves developer experience without introducing risks. The changes make startup logs more informative and easier to read.

---

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(framework-base): add createWithInput and createInRegion #1138
• chore: make startup logs easier to read #1137 👈 (View in Graphite)
• chore: update example cors to not use wildcard #1136
• fix(core): allow studio cors config to fall back to main cors config #1135
• fix(core): default to enabling credentials in cors #1134
• fix(framework-base): params not being passed to actor handle #1133
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[pkg-pr-new]

Open in StackBlitz

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/actor@1137

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/core@1137

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/db@1137

rivetkit

pnpm add https://pkg.pr.new/rivet-gg/rivetkit@1137

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/cloudflare-workers@1137

@rivetkit/redis

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/redis@1137

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/framework-base@1137

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/react@1137

commit: d77cccd

[graphite-app]

Merge activity

• Jul 28, 2:02 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
• Jul 28, 2:03 AM UTC: The Graphite merge queue removed this pull request due to removal of a downstack PR #1133.
• Jul 28, 2:03 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
• Jul 28, 2:05 AM UTC: CI is running for this pull request on a draft pull request (#1139) due to your merge queue CI optimization settings.
• Jul 28, 2:06 AM UTC: Merged by the Graphite merge queue via draft PR: #1139.