chore(core): simplify engine keys

[NathanFlurry]

No description provided.

[claude]

Claude finished @NathanFlurry's task —— View job

---

PR Review: Simplify Engine Keys

Todo List:

• Read repository guidelines (CLAUDE.md)
• Analyze the changed file and understand the modification
• Review for code quality and best practices
• Check for potential bugs or issues
• Assess performance considerations
• Evaluate security concerns
• Review test coverage requirements
• Provide comprehensive feedback

---

Review Summary

This PR simplifies the PERSIST_DATA key in the engine KV driver by changing it from Uint8Array.from([1, 1]) to Uint8Array.from([1]).

Code Quality & Best Practices ✅

• Clean and minimal change: The modification is focused and purposeful
• Consistent formatting: Follows the existing code style
• Clear intent: The change aligns with the PR title "simplify engine keys"

Potential Issues & Considerations

🔄 Breaking Change Concern

This change could potentially be a breaking change if:

• Existing persisted data uses the [1, 1] key format
• Other parts of the system expect the two-byte key format
• There are migrations or backward compatibility requirements

Recommendation: Ensure this change doesn't break existing data persistence or require a migration strategy.

🧪 Test Coverage

• Missing context: No test files were modified in this PR
• Recommendation: Verify that existing tests still pass and consider adding tests that validate the key format if they don't exist

📝 Documentation

• PR description: The PR has no description explaining the rationale for this change
• Recommendation: Add context about why this simplification was made and confirm it's safe

Performance Considerations ✅

• Positive impact: Reducing the key size from 2 bytes to 1 byte is a minor performance improvement
• Memory efficiency: Slightly reduced memory footprint for key storage

Security Concerns ✅

• Low risk: This change doesn't introduce security vulnerabilities
• Key collision: The single-byte key should still provide adequate uniqueness for its intended use

Questions for Author

1. Migration needed? Are there existing deployments with data stored using the [1, 1] key that need to be migrated?
2. Test validation? Have you confirmed all tests pass with this change?
3. Context? What prompted this simplification - was the extra byte unnecessary from the start?

Overall Assessment

LGTM with caveats - The change itself is clean and appears beneficial, but I recommend confirming there are no backward compatibility issues before merging.

---

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(core): fix websockets #1229
• fix(inspector): make inspector work again #1228
• chore(core): remove manager driver #1227
• fix(core): fix issue deserializing WebSocket message with BARE #1226
• chore(core): fix simple engine test #1225
• chore(core): simplify engine keys #1224 👈 (View in Graphite)
• chore(core): remove engine runner addresses config #1223
• chore(core): add welcome message #1222
• chore(fs): remove unneeded warning for onRunnerStart #1221
• chore(core): add readme #1220
• chore(core): add logger to engine runner #1219
• chore(core): update engine runner #1218
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[pkg-pr-new]

More templates

• example-ai-agent
• example-better-auth-external-db
• chat-room
• example-cloudflare-workers
• example-cloudflare-workers-hono
• counter
• example-crdt
• example-database
• example-sqlite
• example-elysia
• example-express
• example-game
• example-hono
• example-hono-react
• example-next-js
• example-rate
• example-raw-fetch-handler
• example-raw-websocket-handler-proxy
• example-react
• starter
• example-stream
• example-sync
• example-tenant
• example-trpc

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/actor@1224

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/cloudflare-workers@1224

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/core@1224

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/db@1224

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/framework-base@1224

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/next-js@1224

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/react@1224

rivetkit

pnpm add https://pkg.pr.new/rivet-gg/rivetkit@1224

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/sql-loader@1224

commit: 09ab4a4

[graphite-app]

Merge activity

• Sep 16, 1:24 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
• Sep 16, 1:24 AM UTC: CI is running for this pull request on a draft pull request (#1232) due to your merge queue CI optimization settings.
• Sep 16, 1:25 AM UTC: Merged by the Graphite merge queue via draft PR: #1232.