feat(react): expose allowTransparency prop on ProcessTerminal#298
Open
Crunchyman-ralph wants to merge 2 commits intorivet-dev:mainfrom
Open
feat(react): expose allowTransparency prop on ProcessTerminal#298Crunchyman-ralph wants to merge 2 commits intorivet-dev:mainfrom
Crunchyman-ralph wants to merge 2 commits intorivet-dev:mainfrom
Conversation
Default stays `true` to preserve current behaviour. Consumers can pass `false` to opt out of the upstream ghostty-web@0.4.0 transparent-bg canvas bug (coder/ghostty-web#116, unreleased per coder/ghostty-web#137) without having to fork the component. Fixes rivet-dev#297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line change: adds an optional
allowTransparencyprop toProcessTerminal, forwarded to theghostty.Terminalconstructor. Default remainstrue, so existing behaviour is unchanged.Lets consumers opt out of the upstream ghostty-web@0.4.0 transparent-background canvas bug (coder/ghostty-web#116 — fix merged but unreleased per coder/ghostty-web#137) without having to fork the component.
Fixes #297