refactor(v8-bridge): modularize the bridge into a per-subsystem TypeScript package#165
Merged
Conversation
…dule-loader into per-subsystem modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #164. Finishes turning the V8 bridge into a clean multi-file TypeScript package and removes the generated intermediate.
crates/execution/assets/v8-bridge.source.jsseam:build-v8-bridge.mjsnow generates the readable bundle in memory frombridge-src/index.tsand minifies it directly, so there is no generated.source.jsto keep in sync.network.tsinto net/http/http2/dns/tls/dgram/fetch/sqlite, andprocess.tsinto process/console/stdin/timers/crypto/vm/v8/perf/misc-stubs.polyfills.tsinto text-encoding/dom-events/abort/web-streams-fallback, extract the misfiled Undici client out ofchild-process.tsinto its own module, and split the builtin-module registry out ofmodule-loader.ts.require('tty')andrequire('sqlite').LinkPackageroute, itsConfigureVmRequesttest constructors set the newer fields, and the build-tools type check drops a dangling script reference.