feat(pty): canonical-mode line editing (VKILL/VWERASE) + ECHOCTL caret echo#166
Merged
Conversation
…t echo Ports the recovered kernel line-discipline work onto the converged terminal: - pty.rs: VKILL (Ctrl-U kill-line) + VWERASE (Ctrl-W word-erase) control chars and process_input branches; ECHOCTL caret-form control echo; column-accurate erase_sequence helper. - guest_pty.rs: wire the two control chars over tcsetattr/tcgetattr. - 8 new kernel pty unit tests. Double-print: investigated; the convergence model surfaces child stdout once (no PTY-master drain), so no guard is warranted — documented as a TODO.
railway-app
Bot
temporarily deployed
to
secure-exec / secure-exec-pr-166
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovers and ports the displaced kernel PTY line-editing work onto the converged terminal.
pty.rs:VKILL(Ctrl-U, kill-line) +VWERASE(Ctrl-W, word-erase) control chars +process_inputbranches;ECHOCTLcaret-form control-char echo (e.g.0x01→^A); a column-accurateerase_sequencehelper (oneBS SP BSper display column, so caret-echoed control chars erase correctly).guest_pty.rs: wire the two new control chars over thetcsetattr/tcgetattrpath.ptysuite 24/24 green, no existing tests weakened.// TODO(double-print)at the stdio-write site rather than fabricating a fix.main already had
opost/onlcr/LineDiscipline/VERASEfrom the convergence merge; this adds only the missing line-editing.