style: cargo fmt#191
Merged
Merged
Conversation
Member
Author
|
Stack for rivet-dev/secure-exec
Get stack: |
Guest https.get to an in-guest TLS server failed with ERR_AGENTOS_NODE_SYNC_RPC: the client upgrade leaves the rustls handshake incomplete (looping would deadlock the guest thread that must service the server-side upgrade), so the first write hit WouldBlock from the loopback transport and surfaced as a fatal sync-RPC error. - Buffer plaintext writes on loopback TLS sockets while the handshake is pending (bounded 4 MiB, warn at 80%, typed error on overflow); the TLS reader thread drives the handshake with a short poll timeout, flushes the buffer on completion, enforces TLS_HANDSHAKE_TIMEOUT, and honors deferred shutdown. - Interrupt flags on the loopback transport let a direct write reclaim the stream mutex from the reader without waiting out its poll. - Bridge: https.createServer now actually upgrades accepted sockets to TLS (options were previously discarded); client secureConnect defers to a macrotask without double-starting the read pump; first-read wake scheduling no longer requires bench metrics to be enabled; localAddress/localPort flow through connect. - New net/tls_loopback_get bench op (guest+node lanes, explicit unsupported native/wasm reasons) and engine support for unsupported-lane rendering. - Regression tests: loopback https round-trip; pending-write buffer cap.
NathanFlurry
force-pushed
the
stack/fix-sidecar-buffer-loopback-tls-writes-while-the-handshake-is-pending-onqnolqm
branch
from
4c621f3 to
9002178
Compare
NathanFlurry
force-pushed
the
stack/style-cargo-fmt-kzmqrmsz
branch
from
e71c976 to
3b8721a
Compare
This was referenced Jul 2, 2026
NathanFlurry
changed the base branch from
stack/fix-sidecar-buffer-loopback-tls-writes-while-the-handshake-is-pending-onqnolqm
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.