fix(sidecar): stop wasm stdin stream-event flood; tolerate shadow-sync races#210
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__kernel_stdin_read), but every host stdin write also emitted astdinstream event to the guest's V8 session. Nothing consumes those events for wasm, and while the guest thread is blocked in a sync bridge call each one lands in the session's bounded deferred-message queue — one dead event per keystroke, killing the session with "sync bridge deferred message queue exceeded limit of 256" after ~256 keystrokes in an interactive shell. Wasm stdin writes now feed the kernel only..swp/.swodance). One transient race then poisoned every subsequent fs op on the VM (lsreturning i/o errors, vimE212on write, sessions dying on the next sync). NotFound/ENOENT during the walk is now treated as "entry mid-churn, skip", matching native semantics.