Skip to content

fix(registry): un-stub brush tab completion on wasi#211

Merged
NathanFlurry merged 1 commit into
mainfrom
fix/wasi-tab-completion
Jul 2, 2026
Merged

fix(registry): un-stub brush tab completion on wasi#211
NathanFlurry merged 1 commit into
mainfrom
fix/wasi-tab-completion

Conversation

@NathanFlurry

Copy link
Copy Markdown
Member
  • Tab completion in the wasi brush build returned an empty candidate list ("NO RECORDS FOUND" on every Tab) because the wasi patch stubbed the completion entry points — upstream drives its async completion generator with tokio::runtime::Handle::current().block_on(...), and the single-threaded wasi tokio build has no runtime to block on.
  • The stubs are replaced with a bounded noop-waker poll loop: the completion future only performs synchronous VFS walks and uncontended lock acquisition, so it resolves on the first polls; the bound bails out to no-completions if a future ever parks on a waker (which a single thread could never wake). Applies to both the reedline and basic input backends.

@railway-app railway-app Bot temporarily deployed to secure-exec / secure-exec-pr-211 July 2, 2026 17:18 Destroyed
@NathanFlurry NathanFlurry merged commit 5367209 into main Jul 2, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant