Merged
Conversation
Implement the solution seen in this thread: https://www.makemkv.com/forum/viewtopic.php?f=3&t=22691&sid=fcc3af9a9b5f95774203ed2690af2884 compiling makemkv was creating a bunch of warnings "defaulted and deleted functions only available with -std=c++11 or -std=gnu++11" causing makemkv.so.1 to fail
Owner
|
Amazing! That's why I love open source - 3 days until someone more knowledgable fixes your issues 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was experiencing the same issues as in issue #51 and took a look at running the dockerfile.
During the process of compiling makemkv it was creating a bunch of warnings "defaulted and deleted functions only available with -std=c++11 or -std=gnu++11" causing makemkv.so.1 to fail.
Looking around I found the solution in this thread and it seems to be working fine now: https://www.makemkv.com/forum/viewtopic.php?f=3&t=22691&sid=fcc3af9a9b5f95774203ed2690af2884