Merged
Conversation
riyazdf
reviewed
Jul 25, 2017
Owner
riyazdf
left a comment
riyazdf
left a comment
There was a problem hiding this comment.
code LGTM, thank you @ashfall!
Looks like there's a CI vendoring issue - I have a hunch that it may be differing versions of vndr (CI uses VNDR_SHA=9909bb2b8a0b7ea464527b376dc50389c90df587)
Which version are you using? Perhaps we can update the VNDR_SHA to match our latest?
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
==========================================
- Coverage 45.47% 45.47% -0.01%
==========================================
Files 193 193
Lines 16061 16061
==========================================
- Hits 7304 7303 -1
- Misses 8379 8380 +1
Partials 378 378 |
Owner
|
This LGTM! I opened #3 for unit testing the original library helper functions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated notary from
v0.4.2to the latest master commit73ff9f33596b657d323f1d6c467b1276defa0033