Draft
Conversation
github-actions
bot
added
rizin
rz-test
RzAnalysis
rz-diff
API
ESIL
RzCore
visual
panel
RzFlag
RZIL
RzAsm-Assembler
labels
thestr4ng3r
force-pushed
the
dist-polymorphic-flag-source
branch
from
6aad9e9 to
0bb2905
Compare
Accessing properties through functions allows the implementation to be swapped out, which is the plan for polymorphic flag sources.
thestr4ng3r
force-pushed
the
dist-polymorphic-flag-source
branch
from
0bb2905 to
86ca00b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This abstracts away the usage of flags from their storage. It enables plugin-like providers for flags, e.g. from symbols, debug info, sections, etc. without the need to "set" flags in a side-effectful way as it is done currently, which has multiple issues:
The new approach can solve this cleanly as flags are calculated on the fly.