Closed
Conversation
Member
|
In such PRs (related to UI) please attach screenshots. |
Member
|
@DimitrisVita I think such ruler should be moved to the left, not the right. Or this can be one more histogram option |
XVilka
requested changes
Dec 18, 2024
Member
XVilka
left a comment
There was a problem hiding this comment.
I also think, that while vertical ruler should be added to horizontal histogram, horitzontal ruler should be added to vertical histogram.
Rot127
previously approved these changes
Dec 18, 2024
b45d2c6 to
ab9a6cf
Compare
Member
|
@DimitrisVita hi, have you had some time to continue working on this? |
Contributor
|
@DimitrisVita if you have any questions, don't hesitate to ask them on the Rizin Dev channel on our Mattermost. |
Contributor
|
Closing this because no activity and reaction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This pull request adds a vertical ruler to the horizontal histogram output in
librz/cons/histogram.c. The ruler includes value ranges and uses a vertical Unicode line character ifscr.utf8=true.I've added y-axis numbering, which is computed as 255 - threshold, where the threshold is calculated for each row. Please let me know if this approach is acceptable or if any adjustments are needed. Should it be added to the interactive histogram too?
Here are two images showing the expected output:
p== 50withscr.utf8=truep== 50withscr.utf8=falseTest plan
scr.utf8=truein the configuration.p==command.scr.utf8=trueand repeat the test to ensure the ruler is displayed correctly without Unicode characters.Closing issues
Addresses #129 but might need improvement