Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Rot127
changed the title
Rot127
requested review from
kazarmy,
ret2libc,
thestr4ng3r and
wargio
as code owners
Rot127
changed the title
/s to /ce and new RzSearch.
Rot127
force-pushed
the
rz-search-s
branch
3 times, most recently
from
2a1a80c to
ab03688
Compare
wargio
left a comment
wargio
left a comment
There was a problem hiding this comment.
For the entropy I would forbid it in the hash command and have 3 new commands to which checks if entropy is less than/equal/greater than
This is important because it is required to setup a hasher. RzHash is normally initialized with all hash-plugins and owned by RzCore. So, if several threads need to hash data, RzHash becomes shared data. And immutability has to be ensured.
Equal wouldn't work too well due to rounding errors. The less than case is nice. But can I open an issue about this please? I have too many other tasks to take care of currently. |
|
Yes. If you want we can merge it as is and I can just fix this with a pr. |
|
Ah this probably should be implemented for entropy and fractional entropy |
- Adds the new command /ch for hash searches and the alias /ce for /s. - Adds search hit details to the entropy hits.
Sounds good to me. |
|
Please rebase |
3 participants
Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
Ports the
/s(calculate blocks entropies and select those above a threshold) and/hto RzSearch and RzShell command/ce./chcommand for hash search and an/cealias forentropy_fractsearch./ch. So the command no loner depends oncore->blocksize.RzSearchHitwithdetails. They can be set arbitrary by the search and printed as well. For the entropy search this is the fractured entropy value.Test plan
Added
Closing issues
...