Fix for stacking mixed output redirects.#5000
Merged
notxvilka merged 1 commit intorizinorg:devfrom Mar 14, 2025
Merged
Conversation
That is redirect to file + redirect to buffer which happens when calling rz_core_cmd_str .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That is redirect to file + redirect to buffer which happens when calling rz_core_cmd_str .
Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
Problem discovered while investigating rizinorg/cutter#3426 but as shown by testcase it's possible to trigger it purely within rizin as well.
In case of cutter it could be simply triggered by running
cmd > outputfilein console widget.Test plan
In addition to command test, I also tested the patch fixes basic redirect case in Cutter.
Closing issues