librz/core+bin: Remove obr (bin rebase command)#5001
Merged
thestr4ng3r merged 1 commit intodevfrom Mar 14, 2025
Merged
Conversation
Rebase done by obr freed all vfiles in the RzBinObject, but did not free the entire RzBinFile, so core was not notified about it, and it may still have had references to vfiles in vfile:// mappings, thus causing UAFs. Unfortunately the entire obr command was not working properly, so we remove it with obR (also not entirely working) and rb being possible replacements depending on the use-case. The possibly dangerous RzBin apis have been made private in the module to prevent future misuse.
Rot127
approved these changes
Mar 14, 2025
notxvilka
approved these changes
Mar 14, 2025
wargio
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
Rebase done by obr freed all vfiles in the RzBinObject, but did not free
the entire RzBinFile, so core was not notified about it, and it may
still have had references to vfiles in vfile:// mappings, thus causing
UAFs.
Unfortunately the entire obr command was not working properly, so we
remove it with obR (also not entirely working) and rb being possible
replacements depending on the use-case.
The possibly dangerous RzBin apis have been made private in the module
to prevent future misuse.
Test plan
The following crashed before: