Skip to content

Comments

Add entropy cmds and detail struct for value extraction#5007

Merged
notxvilka merged 4 commits intodevfrom
fix-entropy-search
Mar 18, 2025
Merged

Add entropy cmds and detail struct for value extraction#5007
notxvilka merged 4 commits intodevfrom
fix-entropy-search

Conversation

@wargio
Copy link
Member

@wargio wargio commented Mar 17, 2025

SQUASH ME

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).

Detailed description

  • Implements entropy commands /ce and /cef as its own search collection.
  • Adds RzSearchHitDetail struct to hold different types of info, such as bytes, string, signed integer, unsigned integer, double.
  • Removes the comment field in favour of RzSearchHitDetail.
  • SM4 keys are now extracted as flag comment when found.
  • Magic search now shows the details and sets them as flag comment

@wargio wargio force-pushed the fix-entropy-search branch from 2e9ee22 to bcd6793 Compare March 18, 2025 05:04
@wargio wargio changed the title Add cef and provide better args for entropy search Improve entropy cmds and add detail container for value extraction on match Mar 18, 2025
@wargio wargio requested a review from Rot127 March 18, 2025 05:10
@wargio wargio changed the title Improve entropy cmds and add detail container for value extraction on match Add entropy cmds and detail struct for value extraction Mar 18, 2025
Copy link
Member

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this one nitpick. Good call with moving the entropy in its own command btw. Search details are also way better than mine. Thanks!

Copy link
Contributor

@notxvilka notxvilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice output enhancement!

@notxvilka notxvilka merged commit 5b5473e into dev Mar 18, 2025
48 checks passed
@notxvilka notxvilka deleted the fix-entropy-search branch March 18, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants