Skip to content

Comments

asan ci: Show ODR violations#5010

Merged
kazarmy merged 2 commits intorizinorg:devfrom
kazarmy:asan-show-odr-violations
Mar 18, 2025
Merged

asan ci: Show ODR violations#5010
kazarmy merged 2 commits intorizinorg:devfrom
kazarmy:asan-show-odr-violations

Conversation

@kazarmy
Copy link
Member

@kazarmy kazarmy commented Mar 18, 2025

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).

Detailed description

This pr makes ASAN show ODR violations since they seem to be easy to fix.

Test plan

All builds are green.

Closing issues

...

@kazarmy
Copy link
Member Author

kazarmy commented Mar 18, 2025

The fix (de5d179) just adds static const since there's only 1 duplicate and the profiles aren't that big.

@kazarmy kazarmy marked this pull request as ready for review March 18, 2025 14:05
@kazarmy kazarmy merged commit dcaf7b9 into rizinorg:dev Mar 18, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants