Skip to content

Conversation

@ltguillaume
Copy link
Contributor

Source: https://github.com/ahkscript/AutoHotkey-Editors (Directives.txt, Commands.txt, Keywords.txt, Functions.txt, Variables.txt, Keys.txt resp.)

Source: https://github.com/ahkscript/AutoHotkey-Editors (Directives.txt, Commands.txt, Keywords.txt, Functions.txt, Variables.txt, Keys.txt resp.)
@hpwamr hpwamr merged commit 23086c4 into rizonesoft:master Sep 16, 2019
@hpwamr
Copy link
Collaborator

hpwamr commented Sep 16, 2019

Hello @ltguillaume , the merging of your PR is done. 👍
ASAP, we will compile a new build.
Please, check it and report in issue #1638 .

@hpwamr
Copy link
Collaborator

hpwamr commented Sep 16, 2019

Hello @ltguillaume
For info, I've corrected your Lexer, because in Notepad3 all Lexers are encoded as "UTF-8 Signature".

@ltguillaume
Copy link
Contributor Author

ltguillaume commented Sep 16, 2019

@hpwamr
Thanks! Apparently, that's what you get when using a shortcut: for this PR, I just used GitHub's web interface to create a fork+patch branch and pasted the changes into the text field. I've never seen GitHub's interface convert a file's encoding FROM UTF-8 before. Now I'm guessing it sports some check on the characters used in the file and converts to ANSI if no Unicode characters are present.

@hpwamr
Copy link
Collaborator

hpwamr commented Sep 16, 2019

@ltguillaume ,
It's a problem that with "GitHub's web interface" you have NO control !
If you have created a Fork, then use Github Desktop or Sourcetree or another solution... o create a Local Sync copy (create a branch is correct but not essential):

  • Now from your PC/laptop edit the file with "Notepad3" 😉 , so you will sure that the "Encoding" is preserve.
  • Then Commit/Push your file to your Remote Fork.
  • From there make a "Compare/Pull Request"

@ltguillaume
Copy link
Contributor Author

I know how to use Git, but thanks for the help nonetheless 😊
I just didn't know about these issues with GitHub's web interface, good to know!

I saw issues with 2636, does this build already include the lexer converted back to UTF-8? If so, there's something fishy going on... (see #1638)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants