feat: add vault creation from VaultSelect screen#340
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
rjroy
force-pushed
the
feat/335-add-vault
branch
from
24e62df to
ff29a45
Compare
Adds an "Add Vault" card at the end of the vault list that opens a dialog for creating new vaults. The vault title is converted to a safe directory name (lowercase, alphanumeric, hyphens) with automatic uniqueness via numeric suffix. Creates the directory and CLAUDE.md, then runs vault setup. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add AddVaultDialog component tests (33 tests) - Add create_vault handler tests in websocket-handler (7 tests) - Add Add Vault integration tests in VaultSelect (11 tests) Addresses coverage requirements: - AddVaultDialog.tsx: comprehensive dialog behavior coverage - websocket-handler.ts: create_vault handler error paths - VaultSelect.tsx: Add Vault card and dialog integration Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The tests were failing intermittently because simulateMessage triggers React state updates outside of React's test control. Fixed by: 1. Wait for "Creating..." state before simulating server response - Ensures addVaultCreating flag is set before vault_created check 2. Wrap simulateMessage calls in act() to flush React updates - Ensures all state updates are processed before assertions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
rjroy
force-pushed
the
feat/335-add-vault
branch
from
615bc3f to
ec28ee8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #335
Test plan
🤖 Generated with Claude Code