fix: Send select_vault on each WebSocket connection#383
Merged
Conversation
Components using useWebSocket() each create separate connections with independent server-side state. The previous refactor (d590f39) moved vault selection to MainContent, but NoteCapture/MoveDialog/HealthPanel still have their own connections that need vault context. - NoteCapture: Add select_vault on connect, update meeting state locally - MoveDialog: Add select_vault on connect for list_directory calls - HealthPanel: Add select_vault on connect for dismiss_health_issue calls Fixes capture and meeting mode being broken after #378. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Each component calling
useWebSocket()creates a separate WebSocket connection with independent server-side state. The previous refactor (#378) moved vault selection logic fromNoteCapturetoMainContent, assuming it would handle all components. But components with their own WebSocket connections still need to sendselect_vaulton their connection before sending vault-specific messages.Changes
select_vaulton connect, also update session context with meeting state directly (since this connection receives themeeting_startedresponse)select_vaulton connect forlist_directorycallsselect_vaulton connect fordismiss_health_issuecallsTest plan
🤖 Generated with Claude Code