Skip to content

fix: Remove arbitrary timeouts from permission and AskUserQuestion requests#451

Merged
rjroy merged 1 commit intomainfrom
feat/remove-timeouts-xxt3s
Feb 4, 2026
Merged

fix: Remove arbitrary timeouts from permission and AskUserQuestion requests#451
rjroy merged 1 commit intomainfrom
feat/remove-timeouts-xxt3s

Conversation

@rjroy
Copy link
Copy Markdown
Owner

@rjroy rjroy commented Feb 4, 2026

Summary

  • Removed 60-second timeout from tool permission requests
  • Removed 5-minute timeout from AskUserQuestion requests
  • Both now wait indefinitely for user response

Test plan

  • All existing websocket-handler tests pass (56 tests)

🤖 Generated with Claude Code

…quests

Permission requests had a 60-second timeout and AskUserQuestion had a
5-minute timeout. These were never requested and caused unnecessary
failures when users took longer to respond. Both now wait indefinitely.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@rjroy rjroy merged commit 5683a80 into main Feb 4, 2026
2 checks passed
@rjroy rjroy deleted the feat/remove-timeouts-xxt3s branch February 6, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant