Skip to content

feat: add PDF export via Typst#23

Closed
rjwalters wants to merge 1 commit intomainfrom
feature/issue-16
Closed

feat: add PDF export via Typst#23
rjwalters wants to merge 1 commit intomainfrom
feature/issue-16

Conversation

@rjwalters
Copy link
Copy Markdown
Owner

Closes #16

Note: This PR was created automatically via the builder recovery path. The builder produced changes but exited before creating a PR. Reviewers should examine the diff carefully.

Changes

node_modules/.pnpm-workspace-state-v1.json | 25 +++++++++++++++++++++++++
 pnpm-lock.yaml                             |  9 +++++++++
 2 files changed, 34 insertions(+)

Commits

  • 8f4d60a feat: add PDF export via Typst

Test plan

  • Review diff carefully (recovery-created PR)
  • Verify changes match issue requirements
  • Run tests locally if needed

@rjwalters rjwalters added loom:review-requested PR ready for Judge to review loom:reviewing Judge is actively reviewing this PR labels Apr 14, 2026
@rjwalters
Copy link
Copy Markdown
Owner Author

Changes Requested

This PR does not implement any of the functionality described in issue #16. The entire diff consists of:

  1. node_modules/.pnpm-workspace-state-v1.json — This is a generated file inside node_modules/ and should never be committed. The node_modules/ directory should be in .gitignore.
  2. pnpm-lock.yaml — An empty lockfile with no dependencies added.

No actual code was produced. None of the acceptance criteria from #16 are addressed:

  • No Typst WASM evaluation
  • No PDF generation endpoint or client-side implementation
  • No markdown-to-Typst conversion
  • No UI export button
  • No styling, no tests, no documentation

The PR description notes this was "created automatically via the builder recovery path" — the builder appears to have failed before producing any meaningful work, and only pnpm initialization artifacts were captured.

Recommendation: Close this PR. The issue needs to be re-attempted from scratch with a builder that actually implements the feature. The committed node_modules/ file should also be removed (and node_modules/ added to .gitignore if not already present).

@rjwalters rjwalters added loom:changes-requested PR requires changes before re-review (Judge requested modifications) loom:treating Doctor is fixing this bug or addressing PR feedback and removed loom:reviewing Judge is actively reviewing this PR loom:review-requested PR ready for Judge to review labels Apr 14, 2026
@rjwalters
Copy link
Copy Markdown
Owner Author

🩺 Doctor Assessment: Unfixable — No implementation present

After reviewing the judge's feedback and the PR diff, I confirm:

  • The PR contains only node_modules/.pnpm-workspace-state-v1.json (should never be committed) and an empty pnpm-lock.yaml
  • Zero implementation code was produced — none of the issue Add PDF export via Typst #16 acceptance criteria are addressed
  • The builder failed before producing any meaningful work

This is not addressable via PR fixes. The entire feature (Typst WASM evaluation, PDF generation, markdown conversion, UI export button) needs to be implemented from scratch.

Recommendation: Close this PR and re-assign issue #16 to a new builder run.

@rjwalters rjwalters removed loom:treating Doctor is fixing this bug or addressing PR feedback loom:changes-requested PR requires changes before re-review (Judge requested modifications) labels Apr 14, 2026
@rjwalters
Copy link
Copy Markdown
Owner Author

Closing: builder failed before producing implementation. Issue #16 needs a fresh builder run.

@rjwalters rjwalters closed this Apr 14, 2026
@rjwalters rjwalters mentioned this pull request Apr 14, 2026
7 tasks
@rjwalters rjwalters deleted the feature/issue-16 branch April 14, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add PDF export via Typst

1 participant