docs(m11): refresh stale deferred-work statuses (F19/F20 save bracket, LOW1)#37
Open
JunzheJoe wants to merge 1 commit into
Open
docs(m11): refresh stale deferred-work statuses (F19/F20 save bracket, LOW1)#37JunzheJoe wants to merge 1 commit into
JunzheJoe wants to merge 1 commit into
Conversation
…, LOW1) Two status rows verified during the F1-F12 code review: - F19/F20 (saving): the 'real fix' the historical row calls for — explicit onload -> save_model -> offload bracket — is already implemented in miles/utils/rlix_train_loop.py:203-218. Save side resolved; eval-at-final-rollout remains open. - LOW1: generate_rollout_fully_async does declare and use the rlix_hooks kwarg, so the inspect.signature forward cannot silently no-op on the legacy path. Closed; the experimental-refactor path (which does not thread hooks) is now rejected by C24 (rlops/miles#33). Historical table rows are preserved verbatim per the doc's append-only convention; updates land in the 6.1 addendum with dated markers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two factual status refreshes found during the F1-F12 code review — no code changes, no decisions needed:
F19/F20 (saving) — §6.1 said Unchanged, but the exact "real fix" the historical row prescribes (explicit onload →
save_model→ offload bracket) is already implemented inmiles/utils/rlix_train_loop.py:203-218. Marked the save side resolved; eval-at-final-rollout stays open.LOW1 —
generate_rollout_fully_asyncdeclares and uses therlix_hookskwarg (examples/fully_async/fully_async_rollout.py:225, begin/bump/end at L275/385/422), socall_rollout_fn'sinspect.signatureforward cannot silently no-op on the legacy path. Marked verified-closed in both the §3.5 follow-ups table and the §6.1 entry, with a pointer to C24 (feat(rlix-validation): C24 — fail fast on RLix + experimental rollout refactor miles#33) for the experimental-refactor path.Historical table rows are preserved verbatim per the doc's own append-only convention; updates carry dated markers.