Skip to content

Conversation

@utkarshjp7
Copy link
Member

@utkarshjp7 utkarshjp7 commented Oct 19, 2018

The PR fixes #330.

Removed following files and folders.

  • envs/mujoco/sawyer
  • contrib/ros
  • tests/garage/envs/mujoco/sawyer
  • examples/theano/trpo_sawyer_reacher.py

@utkarshjp7 utkarshjp7 requested a review from a team as a code owner October 19, 2018 21:52
@coveralls
Copy link

coveralls commented Oct 21, 2018

Coverage Status

Coverage increased (+0.02%) to 65.118% when pulling 3ca3499 on remove_sawyer into df640a5 on master.

@codecov
Copy link

codecov bot commented Oct 22, 2018

Codecov Report

Merging #352 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   64.65%   64.68%   +0.02%     
==========================================
  Files         218      212       -6     
  Lines       14337    13977     -360     
==========================================
- Hits         9270     9041     -229     
+ Misses       5067     4936     -131
Impacted Files Coverage Δ
garage/envs/mujoco/gather/gather_env.py 56.56% <0%> (-1.02%) ⬇️
garage/envs/mujoco/maze/maze_env.py 82.21% <0%> (+1.44%) ⬆️
garage/theano/optimizers/first_order_optimizer.py 85.5% <0%> (+1.44%) ⬆️
garage/envs/mujoco/point_env.py 77.77% <0%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df640a5...3ca3499. Read the comment docs.

@ryanjulian
Copy link
Member

Please make sure we can run these environments in the other repo(from garage) before submitting this change.

@utkarshjp7
Copy link
Member Author

utkarshjp7 commented Oct 24, 2018

The build is failing because some commit messages are not capitalized.
@ryanjulian Should I close this one and create another pull request with capitalized commit messages?

@ryanjulian
Copy link
Member

Use git rebase -i master to rewrite your commit messages.

@ryanjulian
Copy link
Member

Please read CONTRIBUTING.md about why you shouldn't use git merge or merge commits.

@utkarshjp7 utkarshjp7 self-assigned this Oct 26, 2018
@utkarshjp7 utkarshjp7 merged commit 828f6ad into master Oct 26, 2018
@ryanjulian ryanjulian deleted the remove_sawyer branch October 26, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Sawyer environments and contrib.ros to a different repository

5 participants