Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Feb 28, 2019

Both scripts check_test and check_cronjob_test are used when running
Travis CI, and it was observed that the CI was still passing if any of
the commands in the scripts failed.
The argument -e is now set in both scripts to exit the scripts with non-
zero status if case any of their commands fail.

Both scripts check_test and check_cronjob_test are used when running
Travis CI, and it was observed that the CI was still passing if any of
the commands in the scripts failed.
The argument -e is now set in both scripts to exit the scripts with non-
zero status if case any of their commands fail.
@ghost ghost added the bug Something isn't working label Feb 28, 2019
@ghost ghost requested review from gautams3 and naeioi February 28, 2019 20:35
@ghost ghost self-requested a review as a code owner February 28, 2019 20:35
@ghost
Copy link
Author

ghost commented Feb 28, 2019

This is a backport of #544 for release 2018.10.1

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #552 into release-2018.10 will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2018.10     #552      +/-   ##
===================================================
+ Coverage            64.87%   64.93%   +0.06%     
===================================================
  Files                  213      213              
  Lines                13833    13833              
===================================================
+ Hits                  8974     8983       +9     
+ Misses                4859     4850       -9
Impacted Files Coverage Δ
.../theano/optimizers/conjugate_gradient_optimizer.py 74.05% <0%> (+0.63%) ⬆️
garage/envs/mujoco/gather/gather_env.py 57.91% <0%> (+1.34%) ⬆️
garage/theano/optimizers/first_order_optimizer.py 85.5% <0%> (+1.44%) ⬆️
garage/sampler/stateful_pool.py 69.23% <0%> (+2.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 145733e...ecf9d55. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 65.385% when pulling ecf9d55 on backport-544 into 145733e on release-2018.10.

@ryanjulian ryanjulian merged commit a8242f8 into release-2018.10 Feb 28, 2019
@ryanjulian ryanjulian deleted the backport-544 branch February 28, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants