feat: add real-time conventional commit linting#108
Merged
Conversation
Integrated `go-conventionalcommits` to provide instant feedback in the commit view. The UI now validates the message structure against conventional commit standards and checks for line length constraints (50 characters for subject, 72 for body).
Contributor
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements commit message linting using the go-conventionalcommits library, enforcing length constraints on subject and body lines within the UI. Feedback highlights a critical syntax error in the uintPtr function and a potential runtime panic in the border rendering logic due to unchecked padding calculations. Recommendations were also made to use character width instead of byte length for validation and to improve the robustness of error parsing from the linting library.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Coverage Report for CI Build 26342390493Coverage decreased (-0.5%) to 31.165%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Added a check to ensure `padding` calculation does not result in a negative value when the lint error message exceeds the available width, preventing potential `strings.Repeat` runtime panics.
…mmit-summary into feat/conventional-commits * 'feat/conventional-commits' of github.com:rm-hull/git-commit-summary: Update internal/ui/commit_view.go
Removed the unnecessary `//go:fix` comment from the `uintPtr` helper function to clean up the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated
go-conventionalcommitsto provide instant feedback in the commit view. The UI now validates the message structure against conventional commit standards and checks for line length constraints (50 characters for subject, 72 for body).Fixes #104