-
Notifications
You must be signed in to change notification settings - Fork 0
test: Add unit tests & introduce dependency injection #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,212 @@ | ||
| package app | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| type mockProvider struct { | ||
| modelName string | ||
| callFunc func(ctx context.Context, systemPrompt, userPrompt string) (string, error) | ||
| } | ||
|
|
||
| func (m *mockProvider) Call(ctx context.Context, systemPrompt, userPrompt string) (string, error) { | ||
| return m.callFunc(ctx, systemPrompt, userPrompt) | ||
| } | ||
|
|
||
| func (m *mockProvider) Model() string { | ||
| return m.modelName | ||
| } | ||
|
|
||
| type mockGitClient struct { | ||
| DiffFunc func() (string, error) | ||
| CommitFunc func(message string) error | ||
| } | ||
|
|
||
| func (m *mockGitClient) Diff() (string, error) { | ||
| return m.DiffFunc() | ||
| } | ||
|
|
||
| func (m *mockGitClient) Commit(message string) error { | ||
| return m.CommitFunc(message) | ||
| } | ||
|
|
||
| type mockUIClient struct { | ||
| TextAreaFunc func(value string) (string, bool, error) | ||
| StartSpinnerFunc func(message string) | ||
| UpdateSpinnerFunc func(message string) | ||
| StopSpinnerFunc func() | ||
| } | ||
|
|
||
| func (m *mockUIClient) TextArea(value string) (string, bool, error) { | ||
| return m.TextAreaFunc(value) | ||
| } | ||
|
|
||
| func (m *mockUIClient) StartSpinner(message string) { | ||
| if m.StartSpinnerFunc != nil { | ||
| m.StartSpinnerFunc(message) | ||
| } | ||
| } | ||
|
|
||
| func (m *mockUIClient) UpdateSpinner(message string) { | ||
| if m.UpdateSpinnerFunc != nil { | ||
| m.UpdateSpinnerFunc(message) | ||
| } | ||
| } | ||
|
|
||
| func (m *mockUIClient) StopSpinner() { | ||
| if m.StopSpinnerFunc != nil { | ||
| m.StopSpinnerFunc() | ||
| } | ||
| } | ||
|
|
||
| func TestNewApp(t *testing.T) { | ||
| provider := &mockProvider{modelName: "test-model"} | ||
| gitClient := &mockGitClient{} | ||
| uiClient := &mockUIClient{} | ||
|
|
||
| app := NewApp(provider, gitClient, uiClient, "test-prompt") | ||
|
|
||
| assert.NotNil(t, app) | ||
| assert.Equal(t, "test-prompt", app.prompt) | ||
| assert.IsType(t, &mockProvider{}, app.llmProvider) | ||
| assert.IsType(t, &mockGitClient{}, app.git) | ||
| assert.IsType(t, &mockUIClient{}, app.ui) | ||
| } | ||
|
|
||
| func TestAppRun(t *testing.T) { | ||
| ctx := context.Background() | ||
|
|
||
| t.Run("DiffError", func(t *testing.T) { | ||
| mp := &mockProvider{modelName: "test-model"} | ||
| gitClient := &mockGitClient{ | ||
| DiffFunc: func() (string, error) { return "", assert.AnError }, | ||
| } | ||
| uiClient := &mockUIClient{ | ||
| StartSpinnerFunc: func(message string) {}, | ||
| UpdateSpinnerFunc: func(message string) {}, | ||
| StopSpinnerFunc: func() {}, | ||
| } | ||
| app := NewApp(mp, gitClient, uiClient, "prompt") | ||
| err := app.Run(ctx, "") | ||
| assert.Error(t, err) | ||
| assert.Equal(t, assert.AnError, err) | ||
| }) | ||
|
|
||
| t.Run("NoStagedChanges", func(t *testing.T) { | ||
| mp := &mockProvider{modelName: "test-model"} | ||
| gitClient := &mockGitClient{ | ||
| DiffFunc: func() (string, error) { return "", nil }, | ||
| } | ||
| uiClient := &mockUIClient{ | ||
| StartSpinnerFunc: func(message string) {}, | ||
| UpdateSpinnerFunc: func(message string) {}, | ||
| StopSpinnerFunc: func() {}, | ||
| } | ||
| app := NewApp(mp, gitClient, uiClient, "prompt") | ||
| err := app.Run(ctx, "") | ||
| assert.Error(t, err) | ||
| assert.EqualError(t, err, "no changes are staged") | ||
| }) | ||
|
|
||
| t.Run("LLMCallError", func(t *testing.T) { | ||
| mp := &mockProvider{ | ||
| modelName: "test-model", | ||
| callFunc: func(ctx context.Context, systemPrompt, userPrompt string) (string, error) { return "", assert.AnError }, | ||
| } | ||
| gitClient := &mockGitClient{ | ||
| DiffFunc: func() (string, error) { return "diff output", nil }, | ||
| } | ||
| uiClient := &mockUIClient{ | ||
| StartSpinnerFunc: func(message string) {}, | ||
| UpdateSpinnerFunc: func(message string) {}, | ||
| StopSpinnerFunc: func() {}, | ||
| } | ||
| app := NewApp(mp, gitClient, uiClient, "prompt") | ||
| err := app.Run(ctx, "") | ||
| assert.Error(t, err) | ||
| assert.Equal(t, assert.AnError, err) | ||
| }) | ||
|
|
||
| t.Run("TextAreaError", func(t *testing.T) { | ||
| mp := &mockProvider{ | ||
| modelName: "test-model", | ||
| callFunc: func(ctx context.Context, systemPrompt, userPrompt string) (string, error) { return "llm message", nil }, | ||
| } | ||
| gitClient := &mockGitClient{ | ||
| DiffFunc: func() (string, error) { return "diff output", nil }, | ||
| } | ||
| uiClient := &mockUIClient{ | ||
| TextAreaFunc: func(value string) (string, bool, error) { return "", false, assert.AnError }, | ||
| StartSpinnerFunc: func(message string) {}, | ||
| UpdateSpinnerFunc: func(message string) {}, | ||
| StopSpinnerFunc: func() {}, | ||
| } | ||
| app := NewApp(mp, gitClient, uiClient, "prompt") | ||
| err := app.Run(ctx, "") | ||
| assert.Error(t, err) | ||
| assert.Equal(t, assert.AnError, err) | ||
| }) | ||
|
|
||
| t.Run("UserAborted", func(t *testing.T) { | ||
| mp := &mockProvider{ | ||
| modelName: "test-model", | ||
| callFunc: func(ctx context.Context, systemPrompt, userPrompt string) (string, error) { return "llm message", nil }, | ||
| } | ||
| gitClient := &mockGitClient{ | ||
| DiffFunc: func() (string, error) { return "diff output", nil }, | ||
| } | ||
| uiClient := &mockUIClient{ | ||
| TextAreaFunc: func(value string) (string, bool, error) { return "", false, nil }, | ||
| StartSpinnerFunc: func(message string) {}, | ||
| UpdateSpinnerFunc: func(message string) {}, | ||
| StopSpinnerFunc: func() {}, | ||
| } | ||
| app := NewApp(mp, gitClient, uiClient, "prompt") | ||
| err := app.Run(ctx, "") | ||
| assert.NoError(t, err) | ||
| }) | ||
|
|
||
| t.Run("CommitError", func(t *testing.T) { | ||
| mp := &mockProvider{ | ||
| modelName: "test-model", | ||
| callFunc: func(ctx context.Context, systemPrompt, userPrompt string) (string, error) { return "llm message", nil }, | ||
| } | ||
| gitClient := &mockGitClient{ | ||
| DiffFunc: func() (string, error) { return "diff output", nil }, | ||
| CommitFunc: func(message string) error { return assert.AnError }, | ||
| } | ||
| uiClient := &mockUIClient{ | ||
| TextAreaFunc: func(value string) (string, bool, error) { return "edited message", true, nil }, | ||
| StartSpinnerFunc: func(message string) {}, | ||
| UpdateSpinnerFunc: func(message string) {}, | ||
| StopSpinnerFunc: func() {}, | ||
| } | ||
| app := NewApp(mp, gitClient, uiClient, "prompt") | ||
| err := app.Run(ctx, "") | ||
| assert.Error(t, err) | ||
| assert.Equal(t, assert.AnError, err) | ||
| }) | ||
|
|
||
| t.Run("Success", func(t *testing.T) { | ||
| mp := &mockProvider{ | ||
| modelName: "test-model", | ||
| callFunc: func(ctx context.Context, systemPrompt, userPrompt string) (string, error) { return "llm message", nil }, | ||
| } | ||
| gitClient := &mockGitClient{ | ||
| DiffFunc: func() (string, error) { return "diff output", nil }, | ||
| CommitFunc: func(message string) error { return nil }, | ||
| } | ||
| uiClient := &mockUIClient{ | ||
| TextAreaFunc: func(value string) (string, bool, error) { return "edited message", true, nil }, | ||
| StartSpinnerFunc: func(message string) {}, | ||
| UpdateSpinnerFunc: func(message string) {}, | ||
| StopSpinnerFunc: func() {}, | ||
| } | ||
| app := NewApp(mp, gitClient, uiClient, "prompt") | ||
| err := app.Run(ctx, "") | ||
| assert.NoError(t, err) | ||
| }) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Printing the 'ABORTED!' message is a UI concern that should be handled by the
uicomponent. To maintain a clean separation of concerns, consider adding a method to theUIinterface for displaying this message (e.g.,ShowAbortMessage()) and call it here. This would remove the direct dependency on thecolorpackage from theapppackage for this message.