Return the $info from the transport in the <transport>.after_request event #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Returns $this->info from the current $transport on blocking transports only - Updated documentation to show the new API to the hooks - Added a test case to validate that it is used at least once and that it's a non-empty array.
Collaborator
|
Thanks for the PR, and sorry for not getting to this sooner. I'm going to update this to fix the tests in a separate PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles issue #191
I couldn't get phpunit to run on the test, it threw errors about autoloading the base test files. I did download and include the phpunit.phar, but I utilized most of the test from the progress test a few lines above, so it should not have any issues.